Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: pkg/analyzer/lib/src/summary/idl.dart

Issue 1687793003: Remove irrelevant TODOs from summary code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * This file is an "idl" style description of the summary format. It 6 * This file is an "idl" style description of the summary format. It
7 * contains abstract classes which declare the interface for reading data from 7 * contains abstract classes which declare the interface for reading data from
8 * summaries. It is parsed and transformed into code that implements the 8 * summaries. It is parsed and transformed into code that implements the
9 * summary format. 9 * summary format.
10 * 10 *
(...skipping 30 matching lines...) Expand all
41 */ 41 */
42 library analyzer.tool.summary.idl; 42 library analyzer.tool.summary.idl;
43 43
44 import 'base.dart' as base; 44 import 'base.dart' as base;
45 import 'format.dart' as generated; 45 import 'format.dart' as generated;
46 46
47 /** 47 /**
48 * Annotation describing information which is not part of Dart semantics; in 48 * Annotation describing information which is not part of Dart semantics; in
49 * other words, if this information (or any information it refers to) changes, 49 * other words, if this information (or any information it refers to) changes,
50 * static analysis and runtime behavior of the library are unaffected. 50 * static analysis and runtime behavior of the library are unaffected.
51 *
52 * TODO(paulberry): some informative information is currently missing from the
53 * summary format.
54 */ 51 */
55 const informative = null; 52 const informative = null;
56 53
57 /** 54 /**
58 * Annotation describing information which is not part of the public API to a
59 * library; in other words, if this information (or any information it refers
60 * to) changes, libraries outside this one are unaffected.
61 *
62 * TODO(paulberry): currently the summary format does not contain private
63 * information.
64 */
65 const private = null;
66
67 /**
68 * Annotation describing a class which can be the top level object in an 55 * Annotation describing a class which can be the top level object in an
69 * encoded summary. 56 * encoded summary.
70 */ 57 */
71 const topLevel = null; 58 const topLevel = null;
72 59
73 /** 60 /**
74 * Summary information about a reference to a an entity such as a type, top 61 * Summary information about a reference to a an entity such as a type, top
75 * level executable, or executable within a class. 62 * level executable, or executable within a class.
76 */ 63 */
77 abstract class EntityRef extends base.SummaryClass { 64 abstract class EntityRef extends base.SummaryClass {
(...skipping 1597 matching lines...) Expand 10 before | Expand all | Expand 10 after
1675 * 1662 *
1676 * Non-propagable variables have a [propagatedTypeSlot] of zero. 1663 * Non-propagable variables have a [propagatedTypeSlot] of zero.
1677 */ 1664 */
1678 int get propagatedTypeSlot; 1665 int get propagatedTypeSlot;
1679 1666
1680 /** 1667 /**
1681 * Declared type of the variable. Absent if the type is implicit. 1668 * Declared type of the variable. Absent if the type is implicit.
1682 */ 1669 */
1683 EntityRef get type; 1670 EntityRef get type;
1684 } 1671 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698