Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_test.dart

Issue 1687793003: Remove irrelevant TODOs from summary code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_ast.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_test.dart b/pkg/analyzer/test/src/summary/resynthesize_test.dart
index d51c40200fe397fbffa8ebab166672d11b2885e0..7bef16d074150ad0ce6624e41206e3ce5d1d4f44 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_test.dart
@@ -520,7 +520,6 @@ class ResynthTest extends ResolverTestCase {
void compareFieldElements(
FieldElementImpl resynthesized, FieldElementImpl original, String desc) {
comparePropertyInducingElements(resynthesized, original, desc);
- // TODO(paulberry): test evaluationResult
}
void compareFunctionElements(
@@ -684,7 +683,6 @@ class ResynthTest extends ResolverTestCase {
TopLevelVariableElementImpl original,
String desc) {
comparePropertyInducingElements(resynthesized, original, desc);
- // TODO(paulberry): test evaluationResult
}
void compareTypeImpls(
@@ -2243,12 +2241,10 @@ f() {}''');
}
test_function_parameter_kind_named() {
- // TODO(paulberry): also test default value.
checkLibrary('f({x}) {}');
}
test_function_parameter_kind_positional() {
- // TODO(paulberry): also test default value.
checkLibrary('f([x]) {}');
}
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_ast.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698