Add presubmit warning about deprecated compiled_resources.gyp

Add presubmit warning about deprecated compiled_resources.gyp

Just use v2 instead ;) (compiled_resources2.gyp)

R=maruel@chromium.org,cpu@chromium.org
BUG=585553
Committed: https://crrev.com/37e8e740cb9888582189876d07e0b4dbdc1cae37
Cr-Commit-Position: refs/heads/master@{#374762}

[Dan Beam, 2016-02-09 20:22:11]

Description was changed from

==========
Add presubmit warning about deprecated compiled_resources.gyp

Just use v2 instead ;) (compiled_resources2.gyp)

R=brettw@chromium.org
BUG=585553
==========

to

==========
Add presubmit warning about deprecated compiled_resources.gyp

Just use v2 instead ;) (compiled_resources2.gyp)

R=maruel@chromium.org,cpu@chromium.org
BUG=585553
==========

[Dan Beam, 2016-02-09 20:22:11]

dbeam@chromium.org changed reviewers:
+ cpu@chromium.org, maruel@chromium.org
- brettw@chromium.org

[Dan Beam, 2016-02-09 20:25:02]

+maruel@ for review
+cpu@ for that big stamp of his

[M-A Ruel, 2016-02-09 20:27:59]

lgtm

https://codereview.chromium.org/1686663002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1686663002/diff/20001/PRESUBMIT.py#newcode1551
PRESUBMIT.py:1551: added_paths = map(lambda f: f.LocalPath(), added_files)
added = [
  f.LocalPath() for f in input_api.AffectedFiles() if f.Action() == 'A'
]

https://codereview.chromium.org/1686663002/diff/20001/PRESUBMIT.py#newcode1554
PRESUBMIT.py:1554: 
if not added_compiled_resources:
  return []

is more readable.

[Dan Beam, 2016-02-09 20:33:25]

thanks for the review!

https://codereview.chromium.org/1686663002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1686663002/diff/20001/PRESUBMIT.py#newcode1551
PRESUBMIT.py:1551: added_paths = map(lambda f: f.LocalPath(), added_files)
On 2016/02/09 20:27:59, M-A Ruel wrote:
> added = [
>   f.LocalPath() for f in input_api.AffectedFiles() if f.Action() == 'A'
> ]

Done.

https://codereview.chromium.org/1686663002/diff/20001/PRESUBMIT.py#newcode1554
PRESUBMIT.py:1554: 
On 2016/02/09 20:27:59, M-A Ruel wrote:
> if not added_compiled_resources:
>   return []
> 
> is more readable.

Done.

[cpu_(ooo_6.6-7.5), 2016-02-10 22:05:16]

rubberstamp lgtm

[cpu_(ooo_6.6-7.5), 2016-02-10 22:05:17]

rubberstamp lgtm

[Dan Beam, 2016-02-10 22:18:48]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-02-10 22:18:48]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1686663002/#ps40001
(title: "maruel@ review")

[commit-bot: I haz the power, 2016-02-10 22:21:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1686663002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1686663002/40001

[commit-bot: I haz the power, 2016-02-10 22:58:30]

Description was changed from

==========
Add presubmit warning about deprecated compiled_resources.gyp

Just use v2 instead ;) (compiled_resources2.gyp)

R=maruel@chromium.org,cpu@chromium.org
BUG=585553
==========

to

==========
Add presubmit warning about deprecated compiled_resources.gyp

Just use v2 instead ;) (compiled_resources2.gyp)

R=maruel@chromium.org,cpu@chromium.org
BUG=585553
==========

[commit-bot: I haz the power, 2016-02-10 22:58:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-16 22:32:02]

Description was changed from

==========
Add presubmit warning about deprecated compiled_resources.gyp

Just use v2 instead ;) (compiled_resources2.gyp)

R=maruel@chromium.org,cpu@chromium.org
BUG=585553
==========

to

==========
Add presubmit warning about deprecated compiled_resources.gyp

Just use v2 instead ;) (compiled_resources2.gyp)

R=maruel@chromium.org,cpu@chromium.org
BUG=585553

Committed: https://crrev.com/37e8e740cb9888582189876d07e0b4dbdc1cae37
Cr-Commit-Position: refs/heads/master@{#374762}
==========

[commit-bot: I haz the power, 2016-02-16 22:32:03]

Patchset 3 (id:??) landed as
https://crrev.com/37e8e740cb9888582189876d07e0b4dbdc1cae37
Cr-Commit-Position: refs/heads/master@{#374762}