| Index: PRESUBMIT.py
|
| diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
| index f7d2047c8c176cb685acf4a82bd7ca158ff6a13c..e68057563f761eacf9053d63cdadd5b9f5a7e20d 100644
|
| --- a/PRESUBMIT.py
|
| +++ b/PRESUBMIT.py
|
| @@ -1545,6 +1545,24 @@ def _CheckSingletonInHeaders(input_api, output_api):
|
| return []
|
|
|
|
|
| +def _CheckNoDeprecatedCompiledResourcesGYP(input_api, output_api):
|
| + """Checks for old style compiled_resources.gyp files."""
|
| + is_compiled_resource = lambda fp: fp.endswith('compiled_resources.gyp')
|
| +
|
| + added_compiled_resources = filter(is_compiled_resource, [
|
| + f.LocalPath() for f in input_api.AffectedFiles() if f.Action() == 'A'
|
| + ])
|
| +
|
| + if not added_compiled_resources:
|
| + return []
|
| +
|
| + return [output_api.PresubmitError(
|
| + "Found new compiled_resources.gyp files:\n%s\n\n"
|
| + "compiled_resources.gyp files are deprecated,\n"
|
| + "please use compiled_resources2.gyp instead" %
|
| + "\n".join(added_compiled_resources))]
|
| +
|
| +
|
| _DEPRECATED_CSS = [
|
| # Values
|
| ( "-webkit-box", "flex" ),
|
| @@ -1676,6 +1694,7 @@ def _CommonChecks(input_api, output_api):
|
| results.extend(_CheckForCopyrightedCode(input_api, output_api))
|
| results.extend(_CheckForWindowsLineEndings(input_api, output_api))
|
| results.extend(_CheckSingletonInHeaders(input_api, output_api))
|
| + results.extend(_CheckNoDeprecatedCompiledResourcesGYP(input_api, output_api))
|
|
|
| if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()):
|
| results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
|
|
|