Add presubmit warning about deprecated compiled_resources.gyp

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
@@ skipping 1527 matching lines @@
 
   if files:
     return [ output_api.PresubmitError(
         'Found base::Singleton<T> in the following header files.\n' +
         'Please move them to an appropriate source file so that the ' +
         'template gets instantiated in a single compilation unit.',
         files) ]
   return []
 
 
+def _CheckNoDeprecatedCompiledResourcesGYP(input_api, output_api):
+  """Checks for old style compiled_resources.gyp files."""
+  added_files = filter(lambda f: f.Action() == 'A', input_api.AffectedFiles())
+  added_paths = map(lambda f: f.LocalPath(), added_files)

[M-A Ruel, 2016/02/09 20:27:59]

added = [
  f.LocalPath() for f in input_api.AffectedFiles() if f.Action() == 'A'
]

[Dan Beam, 2016/02/09 20:33:25]

Done.

+  is_compiled_resource = lambda fp: fp.endswith('compiled_resources.gyp')
+  added_compiled_resources = filter(is_compiled_resource, added_paths)
+

[M-A Ruel, 2016/02/09 20:27:59]

if not added_compiled_resources:
  return []

is more readable.

[Dan Beam, 2016/02/09 20:33:25]

Done.

+  return [output_api.PresubmitError(
+      "Found new compiled_resources.gyp files:\n%s\n\n"
+      "compiled_resources.gyp files are deprecated,\n"
+      "please use compiled_resources2.gyp instead" %
+      "\n".join(added_compiled_resources))] if added_compiled_resources else []
+
+
 _DEPRECATED_CSS = [
   # Values
   ( "-webkit-box", "flex" ),
   ( "-webkit-inline-box", "inline-flex" ),
   ( "-webkit-flex", "flex" ),
   ( "-webkit-inline-flex", "inline-flex" ),
   ( "-webkit-min-content", "min-content" ),
   ( "-webkit-max-content", "max-content" ),
 
   # Properties
@@ skipping 111 matching lines @@
   results.extend(_CheckForAnonymousVariables(input_api, output_api))
   results.extend(_CheckCygwinShell(input_api, output_api))
   results.extend(_CheckUserActionUpdate(input_api, output_api))
   results.extend(_CheckNoDeprecatedCSS(input_api, output_api))
   results.extend(_CheckNoDeprecatedJS(input_api, output_api))
   results.extend(_CheckParseErrors(input_api, output_api))
   results.extend(_CheckForIPCRules(input_api, output_api))
   results.extend(_CheckForCopyrightedCode(input_api, output_api))
   results.extend(_CheckForWindowsLineEndings(input_api, output_api))
   results.extend(_CheckSingletonInHeaders(input_api, output_api))
+  results.extend(_CheckNoDeprecatedCompiledResourcesGYP(input_api, output_api))
 
   if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()):
     results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
         input_api, output_api,
         input_api.PresubmitLocalPath(),
         whitelist=[r'^PRESUBMIT_test\.py$']))
   return results
 
 
 def _CheckAuthorizedAuthor(input_api, output_api):
@@ skipping 261 matching lines @@
   results.extend(input_api.canned_checks.CheckTreeIsOpen(
       input_api,
       output_api,
       json_url='http://chromium-status.appspot.com/current?format=json'))
 
   results.extend(input_api.canned_checks.CheckChangeHasBugField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasDescription(
       input_api, output_api))
   return results