Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168653002: Change device factories to take SkImageInfo instead of SkBitmap::Config (Closed)

Created:
6 years, 10 months ago by reed2
Modified:
6 years, 10 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Change device factories to take SkImageInfo instead of SkBitmap::Config Define SK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG in chrome's gypi patch from issue 167033002 BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13463

Patch Set 1 #

Patch Set 2 : fix PdfViewer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -258 lines) Patch
M dm/DM.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M dm/DMCpuTask.h View 2 chunks +2 lines, -2 lines 0 comments Download
M dm/DMCpuTask.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M dm/DMGpuTask.h View 2 chunks +2 lines, -2 lines 0 comments Download
M dm/DMGpuTask.cpp View 3 chunks +13 lines, -14 lines 0 comments Download
M dm/DMPipeTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMReplayTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMSerializeTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMTileGridTask.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M dm/DMUtil.h View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMUtil.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M experimental/PdfViewer/SkTrackDevice.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M include/core/SkBitmapDevice.h View 4 chunks +11 lines, -12 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkDevice.h View 5 chunks +18 lines, -7 lines 0 comments Download
M include/device/xps/SkXPSDevice.h View 1 chunk +1 line, -5 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 2 chunks +11 lines, -5 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/pdf/SkPDFDevice.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 3 chunks +77 lines, -17 lines 0 comments Download
M src/core/SkCanvas.cpp View 4 chunks +9 lines, -63 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +43 lines, -9 lines 0 comments Download
M src/core/SkDeviceImageFilterProxy.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 8 chunks +61 lines, -34 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 3 chunks +4 lines, -16 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M src/utils/SkGatherPixelRefsAndRects.h View 3 chunks +10 lines, -6 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/CanvasStateTest.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M tests/GpuBitmapCopyTest.cpp View 1 chunk +18 lines, -4 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/LayerDrawLooperTest.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
6 years, 10 months ago (2014-02-15 19:23:20 UTC) #1
reed1
new change to SkDevice.cpp from the older patch fixes the chrome unit_tests. lgtm
6 years, 10 months ago (2014-02-15 22:54:55 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-15 22:55:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/168653002/1
6 years, 10 months ago (2014-02-15 22:55:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-15 23:38:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildEverything http://108.170.219.164:10117/buildstatus?builder=Build-Ubuntu12-GCC-x86_64-Release-Trybot&number=1486
6 years, 10 months ago (2014-02-15 23:38:18 UTC) #6
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-16 00:46:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/168653002/220001
6 years, 10 months ago (2014-02-16 00:46:58 UTC) #8
commit-bot: I haz the power
Change committed as 13463
6 years, 10 months ago (2014-02-16 00:59:37 UTC) #9
reed2
6 years, 10 months ago (2014-02-16 02:06:11 UTC) #10
Message was sent while issue was closed. 
Need to define SK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG when we DEPS roll

Powered by Google App Engine
This is Rietveld 408576698