Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1686443002:
Reland: Enable NV12 VideoFrames on Mac. (Closed)
|
Created:
4 years, 10 months ago by Daniele Castagna Modified:
4 years, 10 months ago CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland: Enable NV12 VideoFrames on Mac.
As described in crbug.com/524582, we observed a reduction in power
consumption when this format is used to display videos directly using
the WindowServer.
The downside of this format is that a conversion from YUV to RGB will
be performed on the GPU using GL when the VideoFrame has to be used
from GL.
BUG=524582
Committed: https://crrev.com/30f1ed90fef395aab3d991feaef5af86235bf235
Cr-Commit-Position: refs/heads/master@{#375720}
Patch Set 1 #Patch Set 2 : Return the correct internal format in GMBFVP. #Patch Set 3 : Set upstream to 1688623002. #
Depends on Patchset: Messages
Total messages: 33 (14 generated)
dcastagna@chromium.org changed reviewers: + ccameron@chromium.org, dalecurtis@chromium.org
dcastagna@chromium.org changed reviewers: + ccameron@chromium.org, dalecurtis@chromium.org
Description was changed from ========== Enable NV12 VideoFrames on Mac. BUG=524582 ========== to ========== Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. BUG=524582 ==========
lgtm
lgtm too
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686443002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686443002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
On 2016/02/11 01:30:15, commit-bot: I haz the power wrote: > Committed patchset #3 (id:40001) This might have broken WebGL 2 tests with videos on Mac 10.10 Intel. See https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Debug%20...
Message was sent while issue was closed.
Description was changed from ========== Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. BUG=524582 ========== to ========== Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. BUG=524582 ==========
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1684123003/ by zmo@chromium.org. The reason for reverting is: Revert to see if the bot recovers..
Message was sent while issue was closed.
On 2016/02/11 03:19:28, Zhenyao Mo wrote: > A revert of this CL (patchset #3 id:40001) has been created in > https://codereview.chromium.org/1684123003/ by mailto:zmo@chromium.org. > > The reason for reverting is: Revert to see if the bot recovers.. Confirmed. Reverting this fixes the failures.
Message was sent while issue was closed.
On 2016/02/11 04:33:15, Zhenyao Mo wrote: > On 2016/02/11 03:19:28, Zhenyao Mo wrote: > > A revert of this CL (patchset #3 id:40001) has been created in > > https://codereview.chromium.org/1684123003/ by mailto:zmo@chromium.org. > > > > The reason for reverting is: Revert to see if the bot recovers.. > > Confirmed. Reverting this fixes the failures. What were the failures? There is no information about which bot or which tests were failing either on this CL or the parent bug (http://crbug.com/524582). Unfortunately, the landing of this CL, as well as the revert, also weren't documented on that bug.
Message was sent while issue was closed.
On 2016/02/11 at 06:22:17, kbr wrote: > On 2016/02/11 04:33:15, Zhenyao Mo wrote: > > On 2016/02/11 03:19:28, Zhenyao Mo wrote: > > > A revert of this CL (patchset #3 id:40001) has been created in > > > https://codereview.chromium.org/1684123003/ by mailto:zmo@chromium.org. > > > > > > The reason for reverting is: Revert to see if the bot recovers.. > > > > Confirmed. Reverting this fixes the failures. > > What were the failures? There is no information about which bot or which tests were failing either on this CL or the parent bug (http://crbug.com/524582). Unfortunately, the landing of this CL, as well as the revert, also weren't documented on that bug. webgl2_conformance_tests on Intel GPU on Mac on Mac-10.10 was failing. Looking at the log it seems that it's failing to compile the shader in gl_image_io_surface.mm: https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Debug%20... The error is: 61:1299:0210/181704:FATAL:gl_helper.cc(36)] Check failed: 1 == value (1 vs. 0)Error compiling shader: ERROR: 0:1: '' : #version required and missing. ERROR: 0:1: 'attribute' : syntax error: syntax error This CL enables 420v IOSurfaces instead of 2vuy IOSurfaces as suggested in the bug. The bug has also linked all the CLs that were needed to do this, what kind of documentation is it missing that you expected to find?
dcastagna@chromium.org changed reviewers: + sievers@chromium.org
Description was changed from ========== Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. BUG=524582 ========== to ========== Reland: Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. Note: crrev.com/1700913003 should address the problems with WebGL 2 video tests. BUG=524582 ==========
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686443002/40001
Message was sent while issue was closed.
Description was changed from ========== Reland: Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. Note: crrev.com/1700913003 should address the problems with WebGL 2 video tests. BUG=524582 ========== to ========== Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. BUG=524582 Committed: https://crrev.com/dcaccb9c51299dfdf2cd925fd1a3ea6c480862a7 Cr-Commit-Position: refs/heads/master@{#374825} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/dcaccb9c51299dfdf2cd925fd1a3ea6c480862a7 Cr-Commit-Position: refs/heads/master@{#374825}
Description was changed from ========== Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. BUG=524582 Committed: https://crrev.com/dcaccb9c51299dfdf2cd925fd1a3ea6c480862a7 Cr-Commit-Position: refs/heads/master@{#374825} ========== to ========== Reland: Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. BUG=524582 ==========
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686443002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Reland: Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. BUG=524582 ========== to ========== Reland: Enable NV12 VideoFrames on Mac. As described in crbug.com/524582, we observed a reduction in power consumption when this format is used to display videos directly using the WindowServer. The downside of this format is that a conversion from YUV to RGB will be performed on the GPU using GL when the VideoFrame has to be used from GL. BUG=524582 Committed: https://crrev.com/30f1ed90fef395aab3d991feaef5af86235bf235 Cr-Commit-Position: refs/heads/master@{#375720} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/30f1ed90fef395aab3d991feaef5af86235bf235 Cr-Commit-Position: refs/heads/master@{#375720} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
