Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: media/video/gpu_memory_buffer_video_frame_pool.cc

Issue 1686443002: Reland: Enable NV12 VideoFrames on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Set upstream to 1688623002. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/renderer_gpu_video_accelerator_factories.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/gpu_memory_buffer_video_frame_pool.cc
diff --git a/media/video/gpu_memory_buffer_video_frame_pool.cc b/media/video/gpu_memory_buffer_video_frame_pool.cc
index 7ac0cd763324765bc657812752e301031e5e0d7a..e7ffd99332be2d29bb1251968d80001562fbfc2f 100644
--- a/media/video/gpu_memory_buffer_video_frame_pool.cc
+++ b/media/video/gpu_memory_buffer_video_frame_pool.cc
@@ -202,8 +202,7 @@ unsigned ImageInternalFormat(VideoPixelFormat format, size_t plane) {
return GL_RED_EXT;
case PIXEL_FORMAT_NV12:
DCHECK_LE(plane, 1u);
- DLOG(WARNING) << "NV12 format not supported yet";
- return 0; // TODO(andresantoso): Implement extension for NV12.
+ return GL_RGB_YCBCR_420V_CHROMIUM;
case PIXEL_FORMAT_UYVY:
DCHECK_EQ(0u, plane);
return GL_RGB_YCBCR_422_CHROMIUM;
« no previous file with comments | « content/renderer/media/renderer_gpu_video_accelerator_factories.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698