Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1688623002:
Don't enable CHROMIUM_ycbcr_420v_image when using mesa. (Closed)
|
Created:
4 years, 10 months ago by Daniele Castagna Modified:
4 years, 10 months ago CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't enable CHROMIUM_ycbcr_420v_image when using mesa.
BUG=524582
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/41bd2e8be707f51c87f1def977cfadda7f715151
Cr-Commit-Position: refs/heads/master@{#374822}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Same for CHROMIUM_iosurface. #
Dependent Patchsets: Messages
Total messages: 19 (7 generated)
Description was changed from ========== Don't enable CHROMIUM_ycbcr_420v_image when using mesa. BUG=524582 ========== to ========== Don't enable CHROMIUM_ycbcr_420v_image when using mesa. BUG=524582 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ==========
dcastagna@chromium.org changed reviewers: + reveman@chromium.org
https://codereview.chromium.org/1688623002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/1688623002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/feature_info.cc:1007: if (gfx::GetGLImplementation() != gfx::kGLImplementationOSMesaGL) { should GL_CHROMIUM_iosurface also be moved inside this scope?
https://codereview.chromium.org/1688623002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/1688623002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/feature_info.cc:1007: if (gfx::GetGLImplementation() != gfx::kGLImplementationOSMesaGL) { On 2016/02/10 at 03:12:14, reveman wrote: > should GL_CHROMIUM_iosurface also be moved inside this scope? Sure, IIRC you mentioned GL_CHROMIUM_iosurface is not used anymore, if that's the case we can just clean that up in another CL. What do you prefer?
https://codereview.chromium.org/1688623002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/1688623002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/feature_info.cc:1007: if (gfx::GetGLImplementation() != gfx::kGLImplementationOSMesaGL) { On 2016/02/10 at 03:14:56, Daniele Castagna wrote: > On 2016/02/10 at 03:12:14, reveman wrote: > > should GL_CHROMIUM_iosurface also be moved inside this scope? > > Sure, IIRC you mentioned GL_CHROMIUM_iosurface is not used anymore, if that's the case we can just clean that up in another CL. > What do you prefer? Moved AddExtensionString("GL_CHROMIUM_iosurface") in the if body.
lgtm
dcastagna@chromium.org changed reviewers: + sievers@chromium.org
+sievers
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688623002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688623002/2
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688623002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688623002/2
Message was sent while issue was closed.
Committed patchset #2 (id:2)
Message was sent while issue was closed.
Description was changed from ========== Don't enable CHROMIUM_ycbcr_420v_image when using mesa. BUG=524582 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Don't enable CHROMIUM_ycbcr_420v_image when using mesa. BUG=524582 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/41bd2e8be707f51c87f1def977cfadda7f715151 Cr-Commit-Position: refs/heads/master@{#374822} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/41bd2e8be707f51c87f1def977cfadda7f715151 Cr-Commit-Position: refs/heads/master@{#374822} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
