Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: ui/views/window/dialog_client_view.cc

Issue 1686433002: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/window/dialog_client_view.cc
diff --git a/ui/views/window/dialog_client_view.cc b/ui/views/window/dialog_client_view.cc
index 569944542f94a7623b6c4c9f96f84cc393728a72..f9a30f9a3eaf037391af398a386758ce65da0502 100644
--- a/ui/views/window/dialog_client_view.cc
+++ b/ui/views/window/dialog_client_view.cc
@@ -129,7 +129,6 @@ bool DialogClientView::CanClose() {
// before: it's a Close action.
if (GetDialogDelegate()->Close()) {
notified_delegate_ = true;
vasilii 2016/02/11 10:37:48 I suspect that you can drop |notified_delegate_|
Evan Stade 2016/02/11 20:02:11 done. I can't repro the original bug on linux beca
- GetDialogDelegate()->OnClosed();
return true;
}
return false;
@@ -377,7 +376,6 @@ gfx::Insets DialogClientView::GetButtonRowInsets() const {
void DialogClientView::Close() {
GetWidget()->Close();
- GetDialogDelegate()->OnClosed();
}
} // namespace views

Powered by Google App Engine
This is Rietveld 408576698