Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: components/app_modal/views/javascript_app_modal_dialog_views.cc

Issue 1686433002: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal/views/javascript_app_modal_dialog_views.cc
diff --git a/components/app_modal/views/javascript_app_modal_dialog_views.cc b/components/app_modal/views/javascript_app_modal_dialog_views.cc
index b45ccbd6633ad27e042f5c01e6e956b6bae4b790..9823f8af7d582f8d75a40f61d2e75c8c2f6f205c 100644
--- a/components/app_modal/views/javascript_app_modal_dialog_views.cc
+++ b/components/app_modal/views/javascript_app_modal_dialog_views.cc
@@ -111,10 +111,6 @@ bool JavaScriptAppModalDialogViews::Accept() {
return true;
}
-void JavaScriptAppModalDialogViews::OnClosed() {
- parent_->OnClose();
-}
-
views::Widget* JavaScriptAppModalDialogViews::GetWidget() {
msw 2016/02/11 18:08:58 nit: reorder these GetWidget impls too, please.
Evan Stade 2016/02/11 20:02:11 Done.
return message_box_view_->GetWidget();
}
@@ -158,4 +154,8 @@ views::View* JavaScriptAppModalDialogViews::GetInitiallyFocusedView() {
return views::DialogDelegate::GetInitiallyFocusedView();
}
+void JavaScriptAppModalDialogViews::WindowClosing() {
+ parent_->OnClose();
+}
+
} // namespace app_modal

Powered by Google App Engine
This is Rietveld 408576698