Remove DialogDelegate::OnClosed() which is redundant with

ui/views/window/dialog_client_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/dialog_client_view.h"
 
 #include <algorithm>
 
 #include "build/build_config.h"
 #include "ui/events/keycodes/keyboard_codes.h"
@@ skipping 110 matching lines @@
 ///////////////////////////////////////////////////////////////////////////////
 // DialogClientView, ClientView overrides:
 
 bool DialogClientView::CanClose() {
   if (notified_delegate_)
     return true;
 
   // The dialog is closing but no Accept or Cancel action has been performed
   // before: it's a Close action.
   if (GetDialogDelegate()->Close()) {
     notified_delegate_ = true;

[vasilii, 2016/02/11 10:37:48]

I suspect that you can drop |notified_delegate_|

[Evan Stade, 2016/02/11 20:02:11]

done. I can't repro the original bug on linux because holding space immediately
closes the js dialog. Is this a windows-specific thing? Would be nice to verify
this doesn't regress that case.

-    GetDialogDelegate()->OnClosed();
     return true;
   }
   return false;
 }
 
 DialogClientView* DialogClientView::AsDialogClientView() {
   return this;
 }
 
 const DialogClientView* DialogClientView::AsDialogClientView() const {
@@ skipping 227 matching lines @@
 
 gfx::Insets DialogClientView::GetButtonRowInsets() const {
   // NOTE: The insets only apply to the buttons, extra view, and footnote view.
   return GetButtonsAndExtraViewRowHeight() == 0 ? gfx::Insets() :
       gfx::Insets(0, kButtonHEdgeMarginNew,
                   kButtonVEdgeMarginNew, kButtonHEdgeMarginNew);
 }
 
 void DialogClientView::Close() {
   GetWidget()->Close();
-  GetDialogDelegate()->OnClosed();
 }
 
 }  // namespace views