Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: build_overrides/webrtc.gni

Issue 1686373002: Allow WebRTC to require Mac 10.7 deployments in GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/mac/mac_sdk.gni ('K') | « build/config/mac/mac_sdk.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_overrides/webrtc.gni
diff --git a/build_overrides/webrtc.gni b/build_overrides/webrtc.gni
index 9b6b1608ca8ec722dc93bcbd58f0e9f8e7e52471..bdd2bd9da5b67e59e4c93c3b285d846e250687a5 100644
--- a/build_overrides/webrtc.gni
+++ b/build_overrides/webrtc.gni
@@ -2,7 +2,16 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+# TODO(https://bugs.chromium.org/p/webrtc/issues/detail?id=5453):
brettw 2016/02/19 22:04:40 Per in-person discussion we were going to rename t
+# switch callers to use rtc_build_with_chromium instead.
build_with_chromium = true
+rtc_build_with_chromium = true
+
+# See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.
+# Some WebRTC targets require the 10.7 deployment version of the Mac SDK,
+# but those targets are only used in non-Chromium builds. We can remove
+# this when Chromium drops 10.6 support and also requires 10.7.
+rtc_require_mac_10_7_deployment = false
# Exclude pulse audio on Chromium since its prerequisites don't require
# pulse audio.
« build/config/mac/mac_sdk.gni ('K') | « build/config/mac/mac_sdk.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698