Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: build/config/mac/mac_sdk.gni

Issue 1686373002: Allow WebRTC to require Mac 10.7 deployments in GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build_overrides/webrtc.gni » ('j') | build_overrides/webrtc.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/mac_sdk.gni
diff --git a/build/config/mac/mac_sdk.gni b/build/config/mac/mac_sdk.gni
index 8767aa4108b85a10780e1795aad7e88df0a1104d..d32e69e362143811af5b42abbf77dffa620d27e3 100644
--- a/build/config/mac/mac_sdk.gni
+++ b/build/config/mac/mac_sdk.gni
@@ -4,12 +4,21 @@
import("//build/config/chrome_build.gni")
+# See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.
+# We can drop the rtc_require_mac_10_7_deployment flag when Chromium
+# also requires a 10.7 deployment target.
+import("//build_overrides/webrtc.gni")
brettw 2016/02/16 22:46:46 We're trying to make the build directory independe
+
declare_args() {
# Minimum supported version of the Mac SDK.
mac_sdk_min = "10.10"
# Minimum supported version of OSX.
- mac_deployment_target = "10.6"
+ if (rtc_require_mac_10_7_deployment) {
+ mac_deployment_target = "10.7"
+ } else {
+ mac_deployment_target = "10.6"
+ }
# Path to a specific version of the Mac SDK, not including a backslash at
# the end. If empty, the path to the lowest version greater than or equal to
« no previous file with comments | « no previous file | build_overrides/webrtc.gni » ('j') | build_overrides/webrtc.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698