Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1686113002: Remove GrTextBlobCache/GrAtlasTextBlob friendliness (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@tc-cleanup-1
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : build warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -78 lines) Patch
M src/gpu/text/GrAtlasTextBlob.h View 6 chunks +30 lines, -11 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 chunk +32 lines, -0 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 5 chunks +7 lines, -10 lines 0 comments Download
M src/gpu/text/GrTextBlobCache.h View 3 chunks +10 lines, -24 lines 0 comments Download
M src/gpu/text/GrTextBlobCache.cpp View 1 1 chunk +0 lines, -33 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
joshualitt
ptal
4 years, 10 months ago (2016-02-10 15:48:59 UTC) #3
jvanverth1
lgtm + comment https://codereview.chromium.org/1686113002/diff/1/src/gpu/text/GrTextBlobCache.h File src/gpu/text/GrTextBlobCache.h (left): https://codereview.chromium.org/1686113002/diff/1/src/gpu/text/GrTextBlobCache.h#oldcode33 src/gpu/text/GrTextBlobCache.h:33: GrAtlasTextBlob* createBlob(int glyphCount, int runCount, size_t ...
4 years, 10 months ago (2016-02-10 16:41:11 UTC) #4
joshualitt
On 2016/02/10 16:41:11, jvanverth1 wrote: > lgtm + comment > > https://codereview.chromium.org/1686113002/diff/1/src/gpu/text/GrTextBlobCache.h > File src/gpu/text/GrTextBlobCache.h ...
4 years, 10 months ago (2016-02-10 16:42:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686113002/1
4 years, 10 months ago (2016-02-10 19:25:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/150) Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 10 months ago (2016-02-10 19:27:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686113002/20001
4 years, 10 months ago (2016-02-10 19:30:23 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 19:55:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/923037724231f11b9249dbb5bf9688835b5ff9b0

Powered by Google App Engine
This is Rietveld 408576698