Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1684733005: Start whittling down GrTextContext (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@tc-cleanup-2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : a bit more tidying #

Total comments: 7

Patch Set 3 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -233 lines) Patch
M src/gpu/text/GrAtlasTextContext.h View 3 chunks +12 lines, -16 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 2 chunks +41 lines, -25 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.h View 1 2 3 chunks +24 lines, -14 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 2 6 chunks +119 lines, -38 lines 0 comments Download
M src/gpu/text/GrTextContext.h View 1 chunk +13 lines, -27 lines 0 comments Download
M src/gpu/text/GrTextContext.cpp View 1 2 chunks +1 line, -113 lines 0 comments Download

Depends on Patchset:

Issue 1686113002 Patch 20001

Dependent Patchsets:

Issue 1685653004 Patch 20001

Messages

Total messages: 12 (6 generated)
joshualitt
I think my ultimate goal here is to delete GrTextContext and move its handful of ...
4 years, 10 months ago (2016-02-10 16:34:22 UTC) #3
robertphillips
https://codereview.chromium.org/1684733005/diff/20001/src/gpu/text/GrAtlasTextContext.h File src/gpu/text/GrAtlasTextContext.h (right): https://codereview.chromium.org/1684733005/diff/20001/src/gpu/text/GrAtlasTextContext.h#newcode35 src/gpu/text/GrAtlasTextContext.h:35: can 'canDraw' be private ? https://codereview.chromium.org/1684733005/diff/20001/src/gpu/text/GrStencilAndCoverTextContext.cpp File src/gpu/text/GrStencilAndCoverTextContext.cpp (right): ...
4 years, 10 months ago (2016-02-10 18:28:45 UTC) #5
joshualitt
https://codereview.chromium.org/1684733005/diff/20001/src/gpu/text/GrAtlasTextContext.h File src/gpu/text/GrAtlasTextContext.h (right): https://codereview.chromium.org/1684733005/diff/20001/src/gpu/text/GrAtlasTextContext.h#newcode35 src/gpu/text/GrAtlasTextContext.h:35: On 2016/02/10 18:28:45, robertphillips wrote: > can 'canDraw' be ...
4 years, 10 months ago (2016-02-10 20:06:05 UTC) #6
robertphillips
https://codereview.chromium.org/1684733005/diff/20001/src/gpu/text/GrAtlasTextContext.h File src/gpu/text/GrAtlasTextContext.h (right): https://codereview.chromium.org/1684733005/diff/20001/src/gpu/text/GrAtlasTextContext.h#newcode35 src/gpu/text/GrAtlasTextContext.h:35: On 2016/02/10 20:06:05, joshualitt wrote: > On 2016/02/10 18:28:45, ...
4 years, 10 months ago (2016-02-10 20:14:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684733005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684733005/40001
4 years, 10 months ago (2016-02-10 20:22:10 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 20:52:24 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e55750e3fe12cbae30eebb10ecb6fcf89ffbea9b

Powered by Google App Engine
This is Rietveld 408576698