Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1684513004: cleanup textblob cache sanity check and prevent it from bitrotting (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : cleanup and vertex bounds assert #

Patch Set 4 : tweaks #

Patch Set 5 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -79 lines) Patch
M src/gpu/text/GrAtlasTextBlob.h View 1 2 3 4 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 2 3 1 chunk +49 lines, -64 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M src/gpu/text/GrTextBlobCache.cpp View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (10 generated)
joshualitt
4 years, 10 months ago (2016-02-10 14:31:39 UTC) #5
joshualitt
4 years, 10 months ago (2016-02-10 14:31:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684513004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684513004/20001
4 years, 10 months ago (2016-02-10 14:33:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/137)
4 years, 10 months ago (2016-02-10 14:34:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684513004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684513004/40001
4 years, 10 months ago (2016-02-10 14:41:32 UTC) #12
joshualitt
Brian, do you have any objection to making GrAtlasTextBlob::Size a permanent member?
4 years, 10 months ago (2016-02-10 15:16:00 UTC) #14
bsalomon
lgtm
4 years, 10 months ago (2016-02-10 16:13:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684513004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684513004/80001
4 years, 10 months ago (2016-02-10 16:22:30 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 16:52:27 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/2f2ee83a9c1ff05a94265b175e51c63fc424d554

Powered by Google App Engine
This is Rietveld 408576698