net/data/name_constraints_unittest/generate_name_constraints.py - Issue 1686003002: Fix GeneralName directoryName parsing in new (unused) name constraints code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/name_constraints_unittest/generate_name_constraints.py

Issue 1686003002: Fix GeneralName directoryName parsing in new (unused) name constraints code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/name_constraints_unittest/directoryname_and_dnsname_and_ipaddress.pem ('k') | net/data/name_constraints_unittest/san-excluded-directoryname.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/name_constraints_unittest/generate_name_constraints.py

diff --git a/net/data/name_constraints_unittest/generate_name_constraints.py b/net/data/name_constraints_unittest/generate_name_constraints.py

index 5f9fa4d7d7ad3c8b5196fea0b29962cddb4ceafc..37ed005ab4710dae9be9c886b1b782e218eb1460 100755

--- a/net/data/name_constraints_unittest/generate_name_constraints.py

+++ b/net/data/name_constraints_unittest/generate_name_constraints.py

@@ -137,7 +137,7 @@ def x400_address():

def directory_name(name):

return str(name).replace(

- 'asn1 = SEQUENCE', 'directoryName = IMPLICIT:4,SEQUENCE')

+ 'asn1 = SEQUENCE', 'directoryName = EXPLICIT:4,SEQUENCE')

def edi_party_name():