Fix various issues with popup/app window layout/drawing.

Fix various issues with popup/app window layout/drawing.

* Moves responsibility for drawing the top and bottom location bar borders back
  to the location bar.  In MD, where these borders are 1 px thick even at >1x
  scales, drawing them in the frame code doesn't work well, since they have
  to be drawn atop the location bar contents.

  One ramification of this is that due to the way the location bar size and
  position is specified, the popup-mode location bar in MD at >1x scale is
  slightly larger than the non-popup location bar.  The only way to fix this is
  to argue with Sebastien that the location bar size/position should be modified
  a bit and I just don't care about this enough.

* Draws the location bar top and bottom borders in the "location bar border"
  color, instead of the toolbar/content separator colors.  This generally leads
  to greater visibility of these borders.

* Draws the location bar side borders (only present in opaque frames) in the
  "location bar border" color, instead of the client edge color.  This looks
  less glitchy.

* Gives the same height, padding, etc. to location bar contents in all modes (to
  the degree possible given the caveats above).

* Moves the window icon 1 px to the left, which looks slightly better in the
  restored case.

* Makes the 2 px at the bottom of the titlebar part of the titlebar bounds, not
  part of the toolbar bounds.  This simplifies some layout code a bit.

* Uses a saner titlebar height calculation, which currently results in the same
  gap between caption buttons and titlebar bottom in restored windows as
  maximized ones.

* Centers the window icon/title vertically within the whole center titlebar
  space.  This is closely entwined with the bullet above.

BUG=585265
TEST=Run Chrome with --top-chrome-md=material --force-device-scale-factor=2.  Open a popup window, screenshot it, load the screenshot in an image editor, and verify the location bar does not have a transparent row just inside either top or bottom border.

Committed: https://crrev.com/68ef33932afca3e855671c8428ee29f506c55a20
Cr-Commit-Position: refs/heads/master@{#375360}

[Peter Kasting, 2016-02-10 07:44:21]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[Peter Kasting, 2016-02-10 07:44:22]

Much of the delta in the frame views is due to unindenting and then reordering
code in the PaintToolbarBackground() methods, since those now only do anything
when the tabstrip is visible and no longer need to check that condition
internally.

The glass frame loses some code since drawing a top separator from
PaintClientEdge() is no longer needed at all.  The opaque frame still needs its
version of this code, however.

This doesn't touch the ash frame -- once
https://codereview.chromium.org/1636703002/ lands, bringing that frame's code
much more in sync with the other two, I will add similar changes to it to this
CL.

[sky, 2016-02-10 17:26:06]

My eyes glaze over when looking at painting changes. I'm assuming it all looks
good. LGTM

[Peter Kasting, 2016-02-11 08:54:15]

Description was changed from

==========
Move responsibility for drawing the location bar top and bottom border in popup
windows back to the location bar.

In MD, where these borders are 1 px thick even at >1x scales, drawing them in
the frame code doesn't work well, since they have to be drawn atop the location
bar contents.

One ramification of this is that due to the way the location bar size and
position is specified, the popup-mode location bar in MD at >1x scale is
slightly larger than the non-popup location bar.  The only way to fix this is to
argue with Sebastien that the location bar size/position should be modified a
bit and I just don't care about this enough.

This fixes some other related issues in popup mode:
* The location bar top and bottom border are now drawn with the "location bar
  border" color, instead of the toolbar/content separator colors.  This
  generally leads to greater visibility of these borders, which looks better to
  me.
* The location bar side borders (only present in opaque frames) are now also the
  "location bar border" color, instead of the client edge color.  This looks
  less glitchy.
* There were some sizing/spacing disagreements, especially in MD, versus
  non-popup windows (e.g. text not being given the same height to use).  Now
  everything gets the correct vertical height and padding in all modes.

BUG=585265
TEST=Run Chrome with --top-chrome-md=material --force-device-scale-factor=2. 
Open a popup window, screenshot it, load the screenshot in an image editor, and
verify the location bar does not have a transparent row just inside either top
or bottom border.
==========

to

==========
Fix various issues with popup/app window layout/drawing.

* Moves responsibility for drawing the top and bottom location bar borders back
  to the location bar.  In MD, where these borders are 1 px thick even at >1x
  scales, drawing them in the frame code doesn't work well, since they have
  to be drawn atop the location bar contents.

  One ramification of this is that due to the way the location bar size and
  position is specified, the popup-mode location bar in MD at >1x scale is
  slightly larger than the non-popup location bar.  The only way to fix this is
  to argue with Sebastien that the location bar size/position should be modified
  a bit and I just don't care about this enough.

* Draws the location bar top and bottom borders in the "location bar border"
  color, instead of the toolbar/content separator colors.  This generally leads
  to greater visibility of these borders.

* Draws the location bar side borders (only present in opaque frames) in the
  "location bar border" color, instead of the client edge color.  This looks
  less glitchy.

* Gives the same height, padding, etc. to location bar contents in all modes (to
  the degree possible given the caveats above).

* Moves the window icon 1 px to the left, which looks slightly better in the
  restored case.

* Makes the 2 px at the bottom of the titlebar part of the titlebar bounds, not
  part of the toolbar bounds.  This simplifies some layout code a bit.

* Uses a saner titlebar height calculation, which currently results in the same
  gap between caption buttons and titlebar bottom in restored windows as
  maximized ones.

* Centers the window icon/title vertically within the whole center titlebar
  space.  This is closely entwined with the bullet above.

BUG=585265
TEST=Run Chrome with --top-chrome-md=material --force-device-scale-factor=2. 
Open a popup window, screenshot it, load the screenshot in an image editor, and
verify the location bar does not have a transparent row just inside either top
or bottom border.
==========

[Peter Kasting, 2016-02-11 08:54:58]

I fixed a variety of further issues in popup/app layout.  I imagine your glazed
eyes don't care but if you want a look you're welcome to take one.

[sky, 2016-02-11 16:39:53]

SLGTM

[Peter Kasting, 2016-02-13 09:49:15]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2016-02-13 09:49:16]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1685763004/#ps80001
(title: "Fix unittest")

[commit-bot: I haz the power, 2016-02-13 09:49:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685763004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685763004/80001

[commit-bot: I haz the power, 2016-02-13 10:45:18]

Description was changed from

==========
Fix various issues with popup/app window layout/drawing.

* Moves responsibility for drawing the top and bottom location bar borders back
  to the location bar.  In MD, where these borders are 1 px thick even at >1x
  scales, drawing them in the frame code doesn't work well, since they have
  to be drawn atop the location bar contents.

  One ramification of this is that due to the way the location bar size and
  position is specified, the popup-mode location bar in MD at >1x scale is
  slightly larger than the non-popup location bar.  The only way to fix this is
  to argue with Sebastien that the location bar size/position should be modified
  a bit and I just don't care about this enough.

* Draws the location bar top and bottom borders in the "location bar border"
  color, instead of the toolbar/content separator colors.  This generally leads
  to greater visibility of these borders.

* Draws the location bar side borders (only present in opaque frames) in the
  "location bar border" color, instead of the client edge color.  This looks
  less glitchy.

* Gives the same height, padding, etc. to location bar contents in all modes (to
  the degree possible given the caveats above).

* Moves the window icon 1 px to the left, which looks slightly better in the
  restored case.

* Makes the 2 px at the bottom of the titlebar part of the titlebar bounds, not
  part of the toolbar bounds.  This simplifies some layout code a bit.

* Uses a saner titlebar height calculation, which currently results in the same
  gap between caption buttons and titlebar bottom in restored windows as
  maximized ones.

* Centers the window icon/title vertically within the whole center titlebar
  space.  This is closely entwined with the bullet above.

BUG=585265
TEST=Run Chrome with --top-chrome-md=material --force-device-scale-factor=2. 
Open a popup window, screenshot it, load the screenshot in an image editor, and
verify the location bar does not have a transparent row just inside either top
or bottom border.
==========

to

==========
Fix various issues with popup/app window layout/drawing.

* Moves responsibility for drawing the top and bottom location bar borders back
  to the location bar.  In MD, where these borders are 1 px thick even at >1x
  scales, drawing them in the frame code doesn't work well, since they have
  to be drawn atop the location bar contents.

  One ramification of this is that due to the way the location bar size and
  position is specified, the popup-mode location bar in MD at >1x scale is
  slightly larger than the non-popup location bar.  The only way to fix this is
  to argue with Sebastien that the location bar size/position should be modified
  a bit and I just don't care about this enough.

* Draws the location bar top and bottom borders in the "location bar border"
  color, instead of the toolbar/content separator colors.  This generally leads
  to greater visibility of these borders.

* Draws the location bar side borders (only present in opaque frames) in the
  "location bar border" color, instead of the client edge color.  This looks
  less glitchy.

* Gives the same height, padding, etc. to location bar contents in all modes (to
  the degree possible given the caveats above).

* Moves the window icon 1 px to the left, which looks slightly better in the
  restored case.

* Makes the 2 px at the bottom of the titlebar part of the titlebar bounds, not
  part of the toolbar bounds.  This simplifies some layout code a bit.

* Uses a saner titlebar height calculation, which currently results in the same
  gap between caption buttons and titlebar bottom in restored windows as
  maximized ones.

* Centers the window icon/title vertically within the whole center titlebar
  space.  This is closely entwined with the bullet above.

BUG=585265
TEST=Run Chrome with --top-chrome-md=material --force-device-scale-factor=2. 
Open a popup window, screenshot it, load the screenshot in an image editor, and
verify the location bar does not have a transparent row just inside either top
or bottom border.
==========

[commit-bot: I haz the power, 2016-02-13 10:45:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-16 22:47:44]

Description was changed from

==========
Fix various issues with popup/app window layout/drawing.

* Moves responsibility for drawing the top and bottom location bar borders back
  to the location bar.  In MD, where these borders are 1 px thick even at >1x
  scales, drawing them in the frame code doesn't work well, since they have
  to be drawn atop the location bar contents.

  One ramification of this is that due to the way the location bar size and
  position is specified, the popup-mode location bar in MD at >1x scale is
  slightly larger than the non-popup location bar.  The only way to fix this is
  to argue with Sebastien that the location bar size/position should be modified
  a bit and I just don't care about this enough.

* Draws the location bar top and bottom borders in the "location bar border"
  color, instead of the toolbar/content separator colors.  This generally leads
  to greater visibility of these borders.

* Draws the location bar side borders (only present in opaque frames) in the
  "location bar border" color, instead of the client edge color.  This looks
  less glitchy.

* Gives the same height, padding, etc. to location bar contents in all modes (to
  the degree possible given the caveats above).

* Moves the window icon 1 px to the left, which looks slightly better in the
  restored case.

* Makes the 2 px at the bottom of the titlebar part of the titlebar bounds, not
  part of the toolbar bounds.  This simplifies some layout code a bit.

* Uses a saner titlebar height calculation, which currently results in the same
  gap between caption buttons and titlebar bottom in restored windows as
  maximized ones.

* Centers the window icon/title vertically within the whole center titlebar
  space.  This is closely entwined with the bullet above.

BUG=585265
TEST=Run Chrome with --top-chrome-md=material --force-device-scale-factor=2. 
Open a popup window, screenshot it, load the screenshot in an image editor, and
verify the location bar does not have a transparent row just inside either top
or bottom border.
==========

to

==========
Fix various issues with popup/app window layout/drawing.

* Moves responsibility for drawing the top and bottom location bar borders back
  to the location bar.  In MD, where these borders are 1 px thick even at >1x
  scales, drawing them in the frame code doesn't work well, since they have
  to be drawn atop the location bar contents.

  One ramification of this is that due to the way the location bar size and
  position is specified, the popup-mode location bar in MD at >1x scale is
  slightly larger than the non-popup location bar.  The only way to fix this is
  to argue with Sebastien that the location bar size/position should be modified
  a bit and I just don't care about this enough.

* Draws the location bar top and bottom borders in the "location bar border"
  color, instead of the toolbar/content separator colors.  This generally leads
  to greater visibility of these borders.

* Draws the location bar side borders (only present in opaque frames) in the
  "location bar border" color, instead of the client edge color.  This looks
  less glitchy.

* Gives the same height, padding, etc. to location bar contents in all modes (to
  the degree possible given the caveats above).

* Moves the window icon 1 px to the left, which looks slightly better in the
  restored case.

* Makes the 2 px at the bottom of the titlebar part of the titlebar bounds, not
  part of the toolbar bounds.  This simplifies some layout code a bit.

* Uses a saner titlebar height calculation, which currently results in the same
  gap between caption buttons and titlebar bottom in restored windows as
  maximized ones.

* Centers the window icon/title vertically within the whole center titlebar
  space.  This is closely entwined with the bullet above.

BUG=585265
TEST=Run Chrome with --top-chrome-md=material --force-device-scale-factor=2. 
Open a popup window, screenshot it, load the screenshot in an image editor, and
verify the location bar does not have a transparent row just inside either top
or bottom border.

Committed: https://crrev.com/68ef33932afca3e855671c8428ee29f506c55a20
Cr-Commit-Position: refs/heads/master@{#375360}
==========

[commit-bot: I haz the power, 2016-02-16 22:47:45]

Patchset 5 (id:??) landed as
https://crrev.com/68ef33932afca3e855671c8428ee29f506c55a20
Cr-Commit-Position: refs/heads/master@{#375360}