chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h - Issue 1685763004: Fix various issues with popup/app window layout/drawing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

Issue 1685763004: Fix various issues with popup/app window layout/drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup

Patch Set: Fix unittest Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/opaque_browser_frame_view.cc ('k') | chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

index 8dc755ff678b762e4b51b63df4a4ebd6d2f6787f..e4e9c393cdc8dd32c277457f2099262f4be93d01 100644

--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

@@ -35,6 +35,7 @@ class OpaqueBrowserFrameViewLayout : public views::LayoutManager {

static const int kIconLeftSpacing;

static const int kIconTitleSpacing;

static const int kCaptionSpacing;

+ static const int kCaptionButtonBottomPadding;

static const int kNewTabCaptionCondensedSpacing;

explicit OpaqueBrowserFrameViewLayout(

@@ -83,10 +84,10 @@ class OpaqueBrowserFrameViewLayout : public views::LayoutManager {

// acts as if the window is restored regardless of the real mode.

int CaptionButtonY(bool restored) const;

- // Returns the thickness of the 3D edge along the bottom of the titlebar. If

+ // Returns the thickness of the 3D edge along the top of the titlebar. If

// |restored| is true, acts as if the window is restored regardless of the

// real mode.

- int TitlebarBottomThickness(bool restored) const;

+ int TitlebarTopThickness(bool restored) const;

// Returns the bounds of the titlebar icon (or where the icon would be if

// there was one).