Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: chrome/browser/ui/views/toolbar/toolbar_view.h

Issue 1685763004: Fix various issues with popup/app window layout/drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup
Patch Set: Fix unittest Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_VIEW_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/observer_list.h" 10 #include "base/observer_list.h"
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 162
163 // views::ViewTargeterDelegate: 163 // views::ViewTargeterDelegate:
164 bool DoesIntersectRect(const views::View* target, 164 bool DoesIntersectRect(const views::View* target,
165 const gfx::Rect& rect) const override; 165 const gfx::Rect& rect) const override;
166 166
167 // AppMenuBadgeController::Delegate: 167 // AppMenuBadgeController::Delegate:
168 void UpdateBadgeSeverity(AppMenuBadgeController::BadgeType type, 168 void UpdateBadgeSeverity(AppMenuBadgeController::BadgeType type,
169 AppMenuIconPainter::Severity severity, 169 AppMenuIconPainter::Severity severity,
170 bool animate) override; 170 bool animate) override;
171 171
172 // Returns the number of pixels above the location bar in non-normal display.
173 int PopupTopSpacing() const;
174
175 // Used to avoid duplicating the near-identical logic of 172 // Used to avoid duplicating the near-identical logic of
176 // ToolbarView::GetPreferredSize() and ToolbarView::GetMinimumSize(). These 173 // ToolbarView::GetPreferredSize() and ToolbarView::GetMinimumSize(). These
177 // two functions call through to GetSizeInternal(), passing themselves as the 174 // two functions call through to GetSizeInternal(), passing themselves as the
178 // function pointer |View::*get_size|. 175 // function pointer |View::*get_size|.
179 gfx::Size GetSizeInternal(gfx::Size (View::*get_size)() const) const; 176 gfx::Size GetSizeInternal(gfx::Size (View::*get_size)() const) const;
180 177
181 // Given toolbar contents of size |size|, returns the total toolbar size. 178 // Given toolbar contents of size |size|, returns the total toolbar size.
182 gfx::Size SizeForContentSize(gfx::Size size) const; 179 gfx::Size SizeForContentSize(gfx::Size size) const;
183 180
184 // Loads the images for all the child views. 181 // Loads the images for all the child views.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 215
219 // The display mode used when laying out the toolbar. 216 // The display mode used when laying out the toolbar.
220 const DisplayMode display_mode_; 217 const DisplayMode display_mode_;
221 218
222 content::NotificationRegistrar registrar_; 219 content::NotificationRegistrar registrar_;
223 220
224 DISALLOW_IMPLICIT_CONSTRUCTORS(ToolbarView); 221 DISALLOW_IMPLICIT_CONSTRUCTORS(ToolbarView);
225 }; 222 };
226 223
227 #endif // CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_VIEW_H_ 224 #endif // CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698