Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: telemetry/telemetry/value/trace.py

Issue 1685683003: Implement Timeline Based Measurement v2 (Closed) Base URL: git@github.com:catapult-project/catapult.git@new_style_results
Patch Set: fix vinn tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/value/trace.py
diff --git a/telemetry/telemetry/value/trace.py b/telemetry/telemetry/value/trace.py
index 147eeea14a5457c1288bf0c3b6bb732b48ed1261..818e15d050fc076af3819d2636fa7bd5663d16ca 100644
--- a/telemetry/telemetry/value/trace.py
+++ b/telemetry/telemetry/value/trace.py
@@ -31,7 +31,7 @@ class TraceValue(value_module.Value):
"""
super(TraceValue, self).__init__(
page, name='trace', units='', important=important,
- description=description, tir_label=None)
+ description=description, tir_label=None, grouping_keys=None)
self._temp_file = self._GetTempFileHandle(trace_data)
self._cloud_url = None
self._serialized_file_handle = None
@@ -79,6 +79,10 @@ class TraceValue(value_module.Value):
def cleaned_up(self):
return self._temp_file is None
+ @property
+ def filename(self):
+ return self._temp_file.GetAbsPath()
+
def GetBuildbotDataType(self, output_context):
return None
« no previous file with comments | « telemetry/telemetry/value/summarizable_unittest.py ('k') | telemetry/telemetry/value/translate_common_values.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698