Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: telemetry/telemetry/value/summarizable_unittest.py

Issue 1685683003: Implement Timeline Based Measurement v2 (Closed) Base URL: git@github.com:catapult-project/catapult.git@new_style_results
Patch Set: fix vinn tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/value/summarizable.py ('k') | telemetry/telemetry/value/trace.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/value/summarizable_unittest.py
diff --git a/telemetry/telemetry/value/summarizable_unittest.py b/telemetry/telemetry/value/summarizable_unittest.py
index eb49290f1373e85c80865c10e8ac93c3d985f8e9..54a94b2156f69537a258333ac637c1f6d1be91f7 100644
--- a/telemetry/telemetry/value/summarizable_unittest.py
+++ b/telemetry/telemetry/value/summarizable_unittest.py
@@ -10,14 +10,14 @@ class SummarizableTest(unittest.TestCase):
def testAsDictWithoutImprovementDirection(self):
value = summarizable.SummarizableValue(
None, 'foo', 'bars', important=False, description='desc',
- tir_label=None, improvement_direction=None)
+ tir_label=None, improvement_direction=None, grouping_keys=None)
self.assertNotIn('improvement_direction', value.AsDict())
def testAsDictWithoutBaseClassEntries(self):
value = summarizable.SummarizableValue(
None, 'foo', 'bars', important=False, description='desc',
- tir_label=None, improvement_direction=None)
+ tir_label=None, improvement_direction=None, grouping_keys=None)
self.assertFalse(value.AsDictWithoutBaseClassEntries())
@@ -25,6 +25,6 @@ class SummarizableTest(unittest.TestCase):
# TODO(eakuefner): Remove this test when we check I.D. in constructor
value = summarizable.SummarizableValue(
None, 'foo', 'bars', important=False, description='desc',
- tir_label=None, improvement_direction='baz')
+ tir_label=None, improvement_direction='baz', grouping_keys=None)
self.assertNotIn('improvement_direction', value.AsDict())
« no previous file with comments | « telemetry/telemetry/value/summarizable.py ('k') | telemetry/telemetry/value/trace.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698