Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: telemetry/telemetry/value/translate_common_values.py

Issue 1685683003: Implement Timeline Based Measurement v2 (Closed) Base URL: git@github.com:catapult-project/catapult.git@new_style_results
Patch Set: fix vinn tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/value/trace.py ('k') | telemetry/telemetry/value/value_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/value/translate_common_values.py
diff --git a/telemetry/telemetry/value/translate_common_values.py b/telemetry/telemetry/value/translate_common_values.py
new file mode 100644
index 0000000000000000000000000000000000000000..ce46452b8920fa4559b17645fa48b0814844589d
--- /dev/null
+++ b/telemetry/telemetry/value/translate_common_values.py
@@ -0,0 +1,35 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+from telemetry.value import failure
+from telemetry.value import improvement_direction
+from telemetry.value import scalar
+
+
+def TranslateMreFailure(mre_failure, page):
+ return failure.FailureValue.FromMessage(mre_failure.stack, page)
+
+
+def TranslateScalarValue(scalar_value, page):
+ assert (scalar_value['type'] == 'numeric' and
+ scalar_value['numeric']['type'] == 'scalar')
+ scalar_value['value'] = scalar_value['numeric']['value']
+
+ name = scalar_value['grouping_keys']['name']
+
+ unit_parts = scalar_value['numeric']['unit'].split('_')
+ if len(unit_parts) != 2:
+ raise ValueError('Must specify improvement direction for value ' + name)
+
+ scalar_value['units'] = unit_parts[0]
+
+ if unit_parts[1] == 'biggerIsBetter':
+ scalar_value['improvement_direction'] = improvement_direction.UP
+ else:
+ assert unit_parts[1] == 'smallerIsBetter'
+ scalar_value['improvement_direction'] = improvement_direction.DOWN
+
+ scalar_value['page'] = page
+ scalar_value['name'] = name
+ del scalar_value['grouping_keys']['name']
+ return scalar.ScalarValue.FromDict(scalar_value, {})
« no previous file with comments | « telemetry/telemetry/value/trace.py ('k') | telemetry/telemetry/value/value_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698