[interpreter] CompilationInfo::unoptimized_code only for OSR.

[interpreter] CompilationInfo::unoptimized_code only for OSR.

The field in question is only needed when the optimizing compiler is
triggered via OSR. All other paths (e.g. from bytecode stream) should
not rely on the unoptimized code being present.

R=yangguo@chromium.org

Committed: https://crrev.com/1986a486bf31621ac8de1c3a37650e091f2493cb
Cr-Commit-Position: refs/heads/master@{#33860}

[Michael Starzinger, 2016-02-09 16:30:01]

mstarzinger@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Michael Starzinger, 2016-02-09 16:30:01]

Yang: PTAL.
Ross: FYI.

[rmcilroy, 2016-02-09 22:06:07]

LGTM with a suggestion.

https://codereview.chromium.org/1685633002/diff/20001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1685633002/diff/20001/src/compiler.h#newcode251
src/compiler.h:251: Handle<Code> unoptimized = Handle<Code>::null()) {
nit - maybe remove these parameters, and instead add a SetOptimizingForOsr
function rather than adding defaults?

[Michael Starzinger, 2016-02-10 10:01:11]

Addressed comments.

https://codereview.chromium.org/1685633002/diff/20001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1685633002/diff/20001/src/compiler.h#newcode251
src/compiler.h:251: Handle<Code> unoptimized = Handle<Code>::null()) {
On 2016/02/09 22:06:07, rmcilroy wrote:
> nit - maybe remove these parameters, and instead add a SetOptimizingForOsr
> function rather than adding defaults?

Done. Nice idea, I like!

[Yang, 2016-02-10 10:04:40]

On 2016/02/10 10:01:11, Michael Starzinger wrote:
> Addressed comments.
> 
> https://codereview.chromium.org/1685633002/diff/20001/src/compiler.h
> File src/compiler.h (right):
> 
>
https://codereview.chromium.org/1685633002/diff/20001/src/compiler.h#newcode251
> src/compiler.h:251: Handle<Code> unoptimized = Handle<Code>::null()) {
> On 2016/02/09 22:06:07, rmcilroy wrote:
> > nit - maybe remove these parameters, and instead add a SetOptimizingForOsr
> > function rather than adding defaults?
> 
> Done. Nice idea, I like!

lgtm.

[Michael Starzinger, 2016-02-10 10:10:20]

Description was changed from

==========
[interpreter] CompilationInfo::unoptimized_code only for OSR.

The field in question is only needed when the optimizing compiler is
triggered via OSR. All other paths (e.g. from bytecode stream) should
not rely un the unoptimized code being present.

R=yangguo@chromium.org
==========

to

==========
[interpreter] CompilationInfo::unoptimized_code only for OSR.

The field in question is only needed when the optimizing compiler is
triggered via OSR. All other paths (e.g. from bytecode stream) should
not rely on the unoptimized code being present.

R=yangguo@chromium.org
==========

[Michael Starzinger, 2016-02-10 10:10:33]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-02-10 10:10:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1685633002/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-02-10 10:10:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685633002/40001

[commit-bot: I haz the power, 2016-02-10 10:28:04]

Description was changed from

==========
[interpreter] CompilationInfo::unoptimized_code only for OSR.

The field in question is only needed when the optimizing compiler is
triggered via OSR. All other paths (e.g. from bytecode stream) should
not rely on the unoptimized code being present.

R=yangguo@chromium.org
==========

to

==========
[interpreter] CompilationInfo::unoptimized_code only for OSR.

The field in question is only needed when the optimizing compiler is
triggered via OSR. All other paths (e.g. from bytecode stream) should
not rely on the unoptimized code being present.

R=yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-02-10 10:28:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-10 10:28:23]

Description was changed from

==========
[interpreter] CompilationInfo::unoptimized_code only for OSR.

The field in question is only needed when the optimizing compiler is
triggered via OSR. All other paths (e.g. from bytecode stream) should
not rely on the unoptimized code being present.

R=yangguo@chromium.org
==========

to

==========
[interpreter] CompilationInfo::unoptimized_code only for OSR.

The field in question is only needed when the optimizing compiler is
triggered via OSR. All other paths (e.g. from bytecode stream) should
not rely on the unoptimized code being present.

R=yangguo@chromium.org

Committed: https://crrev.com/1986a486bf31621ac8de1c3a37650e091f2493cb
Cr-Commit-Position: refs/heads/master@{#33860}
==========

[commit-bot: I haz the power, 2016-02-10 10:28:24]

Patchset 3 (id:??) landed as
https://crrev.com/1986a486bf31621ac8de1c3a37650e091f2493cb
Cr-Commit-Position: refs/heads/master@{#33860}