src/compiler.cc - Issue 1685633002: [interpreter] CompilationInfo::unoptimized_code only for OSR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 1685633002: [interpreter] CompilationInfo::unoptimized_code only for OSR. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_interpreter-pipeline-1

Patch Set: Addressed comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 2d5655002067c71f7da121c49cf11338363d34e6..2e525932ae96592b684e75059d719ade5da8aadd 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -1024,7 +1024,7 @@ MaybeHandle<Code> Compiler::GetLazyCode(Handle<JSFunction> function) {

VMState<COMPILER> state(isolate);

PostponeInterruptsScope postpone(isolate);

- info.SetOptimizing(BailoutId::None(), handle(function->shared()->code()));

+ info.SetOptimizing();

if (GetOptimizedCodeNow(&info)) {

DCHECK(function->shared()->is_compiled());

@@ -1771,7 +1771,7 @@ MaybeHandle<Code> Compiler::GetOptimizedCode(Handle<JSFunction> function,

DCHECK(!isolate->has_pending_exception());

PostponeInterruptsScope postpone(isolate);

- info->SetOptimizing(osr_ast_id, current_code);

+ info->SetOptimizingForOsr(osr_ast_id, current_code);

if (mode == CONCURRENT) {

if (GetOptimizedCodeLater(info.get())) {

« no previous file with comments | « src/compiler.h ('k') | test/cctest/compiler/function-tester.h » ('j') | no next file with comments »