Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1679313002: [interpreter] Make it possible to optimize without parse. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
titzer, rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-language-mode
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Make it possible to optimize without parse. This makes sure we can run through the TurboFan pipeline without having to parse the source when using the bytecode stream as input. This path is now being tested by the BytecodeGraphTester helper. R=titzer@chromium.org,rmcilroy@chromium.org Committed: https://crrev.com/582be2ba09069efe684624e448359eea83d44cc7 Cr-Commit-Position: refs/heads/master@{#33856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/compiler.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Ross: PTAL at everything and also FYI. :) Ben: PTAL specifically at the pipeline changes.
4 years, 10 months ago (2016-02-09 15:09:50 UTC) #1
rmcilroy
Awesome, lgtm, thanks.
4 years, 10 months ago (2016-02-09 22:02:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679313002/1
4 years, 10 months ago (2016-02-10 09:13:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 09:16:14 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/582be2ba09069efe684624e448359eea83d44cc7 Cr-Commit-Position: refs/heads/master@{#33856}
4 years, 10 months ago (2016-02-10 09:16:49 UTC) #7
titzer
4 years, 10 months ago (2016-02-10 09:47:19 UTC) #8
Message was sent while issue was closed.
On 2016/02/10 09:16:49, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/582be2ba09069efe684624e448359eea83d44cc7
> Cr-Commit-Position: refs/heads/master@{#33856}

lgtm

Powered by Google App Engine
This is Rietveld 408576698