Remove blink side texture status caching.

Remove blink side texture status caching.

We could also remove a bunch of duplicated validation, but let's keep
this CL simple for review purpose.

The tex-storage-and-subimage3d.html failure is due to the command buffer
side handling isn't fully implemented.  Will do it in a separate CL.

BUG=570453
TEST=webgl_conformance,webgl2_conformance
R=kbr@chromium.org,bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/036f7e329f1a946ca04de7c5d4a5a52a3ee50733
Cr-Commit-Position: refs/heads/master@{#374839}

[Zhenyao Mo, 2016-02-10 00:19:04]

Description was changed from

==========
Remove blink side texture status caching.

We could also remove a bunch of duplicated validation, but let's keep
this CL simple for review purpose.

The tex-storage-and-subimage3d.html failure is due to the command buffer
side handling isn't fully implemented.  Will do it in a separate CL.

BUG=570453
TEST=webgl_conformance,webgl2_conformance
R=kbr@chromium.org,bajones@chromium.org
==========

to

==========
Remove blink side texture status caching.

We could also remove a bunch of duplicated validation, but let's keep
this CL simple for review purpose.

The tex-storage-and-subimage3d.html failure is due to the command buffer
side handling isn't fully implemented.  Will do it in a separate CL.

BUG=570453
TEST=webgl_conformance,webgl2_conformance
R=kbr@chromium.org,bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-02-10 00:22:08]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 00:22:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684973002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684973002/1

[commit-bot: I haz the power, 2016-02-10 01:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 01:31:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Zhenyao Mo, 2016-02-10 18:51:52]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-02-10 18:52:32]

kbr: PTAL

[commit-bot: I haz the power, 2016-02-10 18:54:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684973002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684973002/20001

[commit-bot: I haz the power, 2016-02-10 20:42:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 20:42:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Russell (switch to Gerrit), 2016-02-11 01:25:01]

This is just awesome! LGTM!

It looks like there's one more remaining failure on Linux. Please ping if it
affects this patch significantly.

https://codereview.chromium.org/1684973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/1684973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:989: //
FIXME: Implement GPU-to-GPU copy path.
Could you provide more details about exactly what's been removed, or is
otherwise unknown, after this patch? That way others could possibly contribute
to putting back in the GPU-to-GPU copy path.

https://codereview.chromium.org/1684973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(left):

https://codereview.chromium.org/1684973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:6031: if
(!maxX.isValid() || ((width % kBlockWidth) && maxX.value() !=
tex->getWidth(target, level))) {
Are all of these compressed texture formats' validity checked by the command
buffer already?

Unfortunately it's difficult to test them all since they require the underlying
hardware to support the format in question.

[Zhenyao Mo, 2016-02-11 02:16:46]

https://codereview.chromium.org/1684973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/1684973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:989: //
FIXME: Implement GPU-to-GPU copy path.
On 2016/02/11 01:25:01, Ken Russell wrote:
> Could you provide more details about exactly what's been removed, or is
> otherwise unknown, after this patch? That way others could possibly contribute
> to putting back in the GPU-to-GPU copy path.

Sure, I'll create a bug with more details.  But let me land as is now to avoid
rebasing.  I'll update with the bug ID in a followup CL.

https://codereview.chromium.org/1684973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(left):

https://codereview.chromium.org/1684973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:6031: if
(!maxX.isValid() || ((width % kBlockWidth) && maxX.value() !=
tex->getWidth(target, level))) {
On 2016/02/11 01:25:01, Ken Russell wrote:
> Are all of these compressed texture formats' validity checked by the command
> buffer already?
> 
> Unfortunately it's difficult to test them all since they require the
underlying
> hardware to support the format in question.

It is my next step to consolidate compressed texture validation.

[Zhenyao Mo, 2016-02-11 02:16:53]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-02-11 02:18:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684973002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684973002/20001

[commit-bot: I haz the power, 2016-02-11 02:26:06]

Committed patchset #2 (id:20001)

[Zhenyao Mo, 2016-02-11 03:05:12]

If this CL causes any webgl conformance test failures, please update the
expectations accordingly if anyone beats me to it.

[commit-bot: I haz the power, 2016-02-16 22:34:07]

Description was changed from

==========
Remove blink side texture status caching.

We could also remove a bunch of duplicated validation, but let's keep
this CL simple for review purpose.

The tex-storage-and-subimage3d.html failure is due to the command buffer
side handling isn't fully implemented.  Will do it in a separate CL.

BUG=570453
TEST=webgl_conformance,webgl2_conformance
R=kbr@chromium.org,bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove blink side texture status caching.

We could also remove a bunch of duplicated validation, but let's keep
this CL simple for review purpose.

The tex-storage-and-subimage3d.html failure is due to the command buffer
side handling isn't fully implemented.  Will do it in a separate CL.

BUG=570453
TEST=webgl_conformance,webgl2_conformance
R=kbr@chromium.org,bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/036f7e329f1a946ca04de7c5d4a5a52a3ee50733
Cr-Commit-Position: refs/heads/master@{#374839}
==========

[commit-bot: I haz the power, 2016-02-16 22:34:08]

Patchset 2 (id:??) landed as
https://crrev.com/036f7e329f1a946ca04de7c5d4a5a52a3ee50733
Cr-Commit-Position: refs/heads/master@{#374839}