Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1684973002: Remove blink side texture status caching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h
index a5ddcdda2cf72fc34512fd3dd92e3459f23d017a..ee9892d26af29becae52ccb8dce97bcb6a675e4f 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h
+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h
@@ -41,16 +41,6 @@ public:
public:
virtual ~WebGLAttachment();
- virtual GLsizei width() const = 0;
- virtual GLsizei height() const = 0;
- virtual GLsizei depth() const = 0;
- virtual GLenum format() const = 0;
- // For texture attachment, type() returns the type of the attached texture.
- // For renderbuffer attachment, the type of the renderbuffer may vary with GL implementation.
- // To avoid confusion, it would be better to not implement type() for renderbuffer attachment and
- // we should always use the internalformat of the renderbuffer and avoid using type() API.
- virtual GLenum type() const = 0;
- virtual bool isCubeComplete() const = 0;
virtual WebGLSharedObject* object() const = 0;
virtual bool isSharedObject(WebGLSharedObject*) const = 0;
virtual bool valid() const = 0;
@@ -78,14 +68,6 @@ public:
void removeAttachmentFromBoundFramebuffer(GLenum target, GLenum attachment);
WebGLSharedObject* getAttachmentObject(GLenum) const;
- GLenum colorBufferFormat() const;
-
- // Software version of glCheckFramebufferStatus(), except that when
- // FRAMEBUFFER_COMPLETE is returned, it is still possible for
- // glCheckFramebufferStatus() to return FRAMEBUFFER_UNSUPPORTED,
- // depending on hardware implementation.
- GLenum checkStatus(const char** reason) const;
-
// WebGL 1 specific:
// 1) can't allow depth_stencil for depth/stencil attachments, and vice versa.
// 2) no conflicting DEPTH/STENCIL/DEPTH_STENCIL attachments.
@@ -106,10 +88,6 @@ public:
GLenum getReadBuffer() const { return m_readBuffer; }
- // If readbuffer is GL_NONE or no image is attached, return false.
- // Note: it's ok for format or type to be nullptr.
- bool getReadBufferFormatAndType(GLenum* format, GLenum* type) const;
-
DECLARE_VIRTUAL_TRACE();
protected:
@@ -120,7 +98,6 @@ protected:
private:
WebGLAttachment* getAttachment(GLenum attachment) const;
- bool isAttachmentComplete(WebGLAttachment* attachedObject, GLenum attachment, const char** reason) const;
// Check if the framebuffer is currently bound.
bool isBound(GLenum target) const;

Powered by Google App Engine
This is Rietveld 408576698