Rename ServiceProvider to InterfaceProvider.

Rename ServiceProvider to InterfaceProvider.

TBR=rockot@chromium.org
R=tsepez@chromium.org

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/957879558abff482bb4703864046a761ae1a55da
Cr-Commit-Position: refs/heads/master@{#374620}

[Ben Goodger (Google), 2016-02-09 21:17:58]

Description was changed from

==========
Rename ServiceProvider to InterfaceProvider.

TBR=rockot@chromium.org
R=tsepez@chromium.org

BUG=
==========

to

==========
Rename ServiceProvider to InterfaceProvider.

TBR=rockot@chromium.org
R=tsepez@chromium.org

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2016-02-09 21:18:22]

Description was changed from

==========
Rename ServiceProvider to InterfaceProvider.

TBR=rockot@chromium.org
R=tsepez@chromium.org

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Rename ServiceProvider to InterfaceProvider.

TBR=rockot@chromium.org
R=tsepez@chromium.org

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2016-02-09 21:19:29]

rockot: all
tsepez:
content/common/application_setup.mojom
content/common/render_frame_setup.mojom
content/common/service_worker/embedded_worker_setup.mojom

Mechanical rename.

[Ben Goodger (Google), 2016-02-10 00:25:25]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 00:26:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684783002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684783002/1

[Tom Sepez, 2016-02-10 00:28:29]

RS LGTM based on sampling a few files.

[Ben Goodger (Google), 2016-02-10 00:30:36]

The CQ bit was unchecked by ben@chromium.org

[Ben Goodger (Google), 2016-02-10 00:30:56]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-02-10 00:34:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684783002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684783002/1

[commit-bot: I haz the power, 2016-02-10 00:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 00:37:54]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_site_isolation on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Marijn Kruisselbrink, 2016-02-10 00:41:43]

https://codereview.chromium.org/1684783002/diff/1/content/child/mojo/mojo_app...
File content/child/mojo/mojo_application.cc (right):

https://codereview.chromium.org/1684783002/diff/1/content/child/mojo/mojo_app...
content/child/mojo/mojo_application.cc:58: mojo::InterfaceProviderPtr services;
drive-by comment: in some places you've renamed service and exposed_services to
interfaces and exposed_interfaces, but in many other places you haven't. It
probably makes sense to change all services/exposed_services
attributes/parameter names to interfaces?

[Ben Goodger (Google), 2016-02-10 00:54:27]

On 2016/02/10 00:41:43, Marijn Kruisselbrink wrote:
>
https://codereview.chromium.org/1684783002/diff/1/content/child/mojo/mojo_app...
> File content/child/mojo/mojo_application.cc (right):
> 
>
https://codereview.chromium.org/1684783002/diff/1/content/child/mojo/mojo_app...
> content/child/mojo/mojo_application.cc:58: mojo::InterfaceProviderPtr
services;
> drive-by comment: in some places you've renamed service and exposed_services
to
> interfaces and exposed_interfaces, but in many other places you haven't. It
> probably makes sense to change all services/exposed_services
> attributes/parameter names to interfaces?

Yeah. This CL was already pretty unwieldy. Also I expect much of the code in
content to churn in the near term as we consolidate mojo/shell access.

[Ben Goodger (Google), 2016-02-10 00:59:16]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-10 00:59:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1684783002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-02-10 01:04:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684783002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684783002/20001

[commit-bot: I haz the power, 2016-02-10 01:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 01:24:05]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Ben Goodger (Google), 2016-02-10 02:34:01]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-10 02:34:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1684783002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-02-10 02:36:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684783002/40001

[commit-bot: I haz the power, 2016-02-10 03:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 03:09:38]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ben Goodger (Google), 2016-02-10 03:40:18]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-10 03:40:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1684783002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-02-10 03:41:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684783002/60001

[commit-bot: I haz the power, 2016-02-10 04:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 04:04:52]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-10 06:24:32]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-10 06:24:33]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1684783002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-02-10 06:24:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684783002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684783002/80001

[commit-bot: I haz the power, 2016-02-10 07:46:31]

Description was changed from

==========
Rename ServiceProvider to InterfaceProvider.

TBR=rockot@chromium.org
R=tsepez@chromium.org

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Rename ServiceProvider to InterfaceProvider.

TBR=rockot@chromium.org
R=tsepez@chromium.org

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-02-10 07:46:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-10 07:47:27]

Description was changed from

==========
Rename ServiceProvider to InterfaceProvider.

TBR=rockot@chromium.org
R=tsepez@chromium.org

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Rename ServiceProvider to InterfaceProvider.

TBR=rockot@chromium.org
R=tsepez@chromium.org

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/957879558abff482bb4703864046a761ae1a55da
Cr-Commit-Position: refs/heads/master@{#374620}
==========

[commit-bot: I haz the power, 2016-02-10 07:47:28]

Patchset 5 (id:??) landed as
https://crrev.com/957879558abff482bb4703864046a761ae1a55da
Cr-Commit-Position: refs/heads/master@{#374620}