Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1687693002: Rename ConnectToService to ConnectToInterface() (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, dcheng, ben+mojo_chromium.org, yusukes+watch_chromium.org, jam, abarth-chromium, nona+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, kalyank, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, feature-media-reviews_chromium.org, yzshen+watch_chromium.org, rjkroege, tfarina, shuchen+watch_chromium.org, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), James Su, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@sp2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ConnectToService to ConnectToInterface() TBR=rockot@chromium.org BUG= Committed: https://crrev.com/e3bc902fc899ba677f5cb8eeefd48da06b4db3c0 Cr-Commit-Position: refs/heads/master@{#374677}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -73 lines) Patch
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/clipboard/clipboard_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/files_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/cpp/prefs/pref_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/public/cpp/font_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_tree_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_manager_client_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_app_connection_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/mojo/mojo_app_connection_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo_shell_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/mojo_app_connection.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M device/devices_app/devices_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/shelf/shelf_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/accelerator_registrar_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/android_mojo_media_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/test_service/test_service_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_time_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_manager_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_manager_apptest_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_manager_apptest_target.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_package_apptest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/capability_filter_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/shell.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/shell/runner/child/native_apptest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/standalone/shell_apptest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M sql/mojo/sql_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/mojo/vfs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/screen_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/surface_binding.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1684783002 Patch 80001

Messages

Total messages: 6 (2 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-10 00:30:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1687693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1687693002/20001
4 years, 10 months ago (2016-02-10 15:21:24 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 17:38:38 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 17:42:24 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e3bc902fc899ba677f5cb8eeefd48da06b4db3c0
Cr-Commit-Position: refs/heads/master@{#374677}

Powered by Google App Engine
This is Rietveld 408576698