Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2510)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 1684783002: Rename ServiceProvider to InterfaceProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 473d5a0de827c69b4a995ed80d93f2887dcddb32..dfa3b6f340212d523143aefacf53c107094349d9 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -370,10 +370,10 @@ class RenderFrameSetupImpl : public RenderFrameSetup {
mojo::InterfaceRequest<RenderFrameSetup> request)
: routing_id_highmark_(-1), binding_(this, std::move(request)) {}
- void ExchangeServiceProviders(
+ void ExchangeInterfaceProviders(
int32_t frame_routing_id,
- mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services)
+ mojo::InterfaceRequest<mojo::InterfaceProvider> services,
+ mojo::InterfaceProviderPtr exposed_services)
override {
// TODO(morrita): This is for investigating http://crbug.com/415059 and
// should be removed once it is fixed.
@@ -414,8 +414,8 @@ blink::WebGraphicsContext3D::Attributes GetOffscreenAttribs() {
}
void SetupEmbeddedWorkerOnWorkerThread(
- mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::InterfacePtrInfo<mojo::ServiceProvider> exposed_services) {
+ mojo::InterfaceRequest<mojo::InterfaceProvider> services,
+ mojo::InterfacePtrInfo<mojo::InterfaceProvider> exposed_services) {
ServiceWorkerContextClient* client =
ServiceWorkerContextClient::ThreadSpecificInstance();
// It is possible for client to be null if for some reason the worker died
@@ -433,10 +433,10 @@ class EmbeddedWorkerSetupImpl : public EmbeddedWorkerSetup {
mojo::InterfaceRequest<EmbeddedWorkerSetup> request)
: binding_(this, std::move(request)) {}
- void ExchangeServiceProviders(
+ void ExchangeInterfaceProviders(
int32_t thread_id,
- mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services) override {
+ mojo::InterfaceRequest<mojo::InterfaceProvider> services,
+ mojo::InterfaceProviderPtr exposed_services) override {
WorkerThreadRegistry::Instance()->GetTaskRunnerFor(thread_id)->PostTask(
FROM_HERE,
base::Bind(&SetupEmbeddedWorkerOnWorkerThread, base::Passed(&services),
@@ -1087,9 +1087,9 @@ void RenderThreadImpl::AddRoute(int32_t routing_id, IPC::Listener* listener) {
return;
scoped_refptr<PendingRenderFrameConnect> connection(it->second);
- mojo::InterfaceRequest<mojo::ServiceProvider> services(
+ mojo::InterfaceRequest<mojo::InterfaceProvider> services(
std::move(connection->services()));
- mojo::ServiceProviderPtr exposed_services(
+ mojo::InterfaceProviderPtr exposed_services(
std::move(connection->exposed_services()));
exposed_services.set_connection_error_handler(mojo::Closure());
pending_render_frame_connects_.erase(it);
@@ -1120,8 +1120,8 @@ void RenderThreadImpl::RemoveEmbeddedWorkerRoute(int32_t routing_id) {
void RenderThreadImpl::RegisterPendingRenderFrameConnect(
int routing_id,
- mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services) {
+ mojo::InterfaceRequest<mojo::InterfaceProvider> services,
+ mojo::InterfaceProviderPtr exposed_services) {
std::pair<PendingRenderFrameConnectMap::iterator, bool> result =
pending_render_frame_connects_.insert(std::make_pair(
routing_id,
@@ -2128,14 +2128,15 @@ void RenderThreadImpl::ReleaseFreeMemory() {
RenderThreadImpl::PendingRenderFrameConnect::PendingRenderFrameConnect(
int routing_id,
- mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services)
+ mojo::InterfaceRequest<mojo::InterfaceProvider> services,
+ mojo::InterfaceProviderPtr exposed_services)
: routing_id_(routing_id),
services_(std::move(services)),
exposed_services_(std::move(exposed_services)) {
- // The RenderFrame may be deleted before the ExchangeServiceProviders message
- // is received. In that case, the RenderFrameHost should close the connection,
- // which is detected by setting an error handler on |exposed_services_|.
+ // The RenderFrame may be deleted before the ExchangeInterfaceProviders
+ // message is received. In that case, the RenderFrameHost should close the
+ // connection, which is detected by setting an error handler on
+ // |exposed_services_|.
exposed_services_.set_connection_error_handler(base::Bind(
&RenderThreadImpl::PendingRenderFrameConnect::OnConnectionError,
base::Unretained(this)));
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/renderer/service_worker/service_worker_context_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698