Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1684543002: [Ignition] Fix separate ignition snapshot for separate toolsets. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Ignition] Fix separate ignition snapshot for separate toolsets. BUG=v8:4280 LOG=N Committed: https://crrev.com/de366e29852faaef14f310496d605314b2fdfd08 Cr-Commit-Position: refs/heads/master@{#33842}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -31 lines) Patch
M tools/gyp/v8.gyp View 1 7 chunks +54 lines, -31 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684543002/20001
4 years, 10 months ago (2016-02-09 10:04:10 UTC) #4
Michael Achenbach
PTAL. The duplication is a bit sad, but I didn't see a better way now...
4 years, 10 months ago (2016-02-09 10:05:04 UTC) #5
rmcilroy
On 2016/02/09 10:05:04, Michael Achenbach wrote: > PTAL. The duplication is a bit sad, but ...
4 years, 10 months ago (2016-02-09 10:11:31 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 10:26:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684543002/20001
4 years, 10 months ago (2016-02-09 10:47:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-09 10:49:18 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 10:49:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de366e29852faaef14f310496d605314b2fdfd08
Cr-Commit-Position: refs/heads/master@{#33842}

Powered by Google App Engine
This is Rietveld 408576698