Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: tools/gyp/v8.gyp

Issue 1684543002: [Ignition] Fix separate ignition snapshot for separate toolsets. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 'dependencies': ['v8_base', 'v8_nosnapshot'], 113 'dependencies': ['v8_base', 'v8_nosnapshot'],
114 }], 114 }],
115 ['v8_use_snapshot=="true" and v8_use_external_startup_data==0', { 115 ['v8_use_snapshot=="true" and v8_use_external_startup_data==0', {
116 # The dependency on v8_base should come from a transitive 116 # The dependency on v8_base should come from a transitive
117 # dependency however the Android toolchain requires libv8_base.a 117 # dependency however the Android toolchain requires libv8_base.a
118 # to appear before libv8_snapshot.a so it's listed explicitly. 118 # to appear before libv8_snapshot.a so it's listed explicitly.
119 'dependencies': ['v8_base', 'v8_snapshot'], 119 'dependencies': ['v8_base', 'v8_snapshot'],
120 }], 120 }],
121 ['v8_use_snapshot=="true" and v8_use_external_startup_data==1 and want_s eparate_host_toolset==0', { 121 ['v8_use_snapshot=="true" and v8_use_external_startup_data==1 and want_s eparate_host_toolset==0', {
122 'dependencies': ['v8_base', 'v8_external_snapshot'], 122 'dependencies': ['v8_base', 'v8_external_snapshot'],
123 'inputs': [ '<(PRODUCT_DIR)/snapshot_blob.bin', ], 123 'inputs': ['<(PRODUCT_DIR)/snapshot_blob.bin'],
124 'conditions': [
125 ['v8_separate_ignition_snapshot==1', {
126 'inputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition.bin'],
127 }],
128 ]
124 }], 129 }],
125 ['v8_use_snapshot=="true" and v8_use_external_startup_data==1 and want_s eparate_host_toolset==1', { 130 ['v8_use_snapshot=="true" and v8_use_external_startup_data==1 and want_s eparate_host_toolset==1', {
126 'dependencies': ['v8_base', 'v8_external_snapshot'], 131 'dependencies': ['v8_base', 'v8_external_snapshot'],
127 'target_conditions': [ 132 'target_conditions': [
128 ['_toolset=="host"', { 133 ['_toolset=="host"', {
129 'inputs': [ 134 'inputs': ['<(PRODUCT_DIR)/snapshot_blob_host.bin'],
130 '<(PRODUCT_DIR)/snapshot_blob_host.bin',
131 ],
132 }, { 135 }, {
133 'inputs': [ 136 'inputs': ['<(PRODUCT_DIR)/snapshot_blob.bin'],
134 '<(PRODUCT_DIR)/snapshot_blob.bin', 137 }],
138 ],
139 'conditions': [
140 ['v8_separate_ignition_snapshot==1', {
141 'target_conditions': [
142 ['_toolset=="host"', {
143 'inputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition_host.bin'],
144 }, {
145 'inputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition.bin'],
146 }],
135 ], 147 ],
136 }], 148 }],
137 ], 149 ],
138 }], 150 }],
139 ['want_separate_host_toolset==1', { 151 ['want_separate_host_toolset==1', {
140 'toolsets': ['host', 'target'], 152 'toolsets': ['host', 'target'],
141 }, { 153 }, {
142 'toolsets': ['target'], 154 'toolsets': ['target'],
143 }], 155 }],
144 ] 156 ]
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 'V8_SHARED', 288 'V8_SHARED',
277 'BUILDING_V8_SHARED', 289 'BUILDING_V8_SHARED',
278 ], 290 ],
279 'direct_dependent_settings': { 291 'direct_dependent_settings': {
280 'defines': [ 292 'defines': [
281 'V8_SHARED', 293 'V8_SHARED',
282 'USING_V8_SHARED', 294 'USING_V8_SHARED',
283 ], 295 ],
284 }, 296 },
285 }], 297 }],
286 # Extra snapshot blob for ignition. Separate host toolset is not 298 # Extra snapshot blob for ignition.
287 # supported.
288 ['v8_separate_ignition_snapshot==1', { 299 ['v8_separate_ignition_snapshot==1', {
289 # This is concatenated to the other actions list of 300 # This is concatenated to the other actions list of
290 # v8_external_snapshot. 301 # v8_external_snapshot.
291 'actions': [ 302 'actions': [
292 { 303 {
293 'action_name': 'run_mksnapshot (ignition)', 304 'action_name': 'run_mksnapshot (ignition)',
294 'inputs': [ 305 'inputs': ['<(mksnapshot_exec)'],
295 '<(mksnapshot_exec)',
296 ],
297 'variables': { 306 'variables': {
298 # TODO: Extract common mksnapshot_flags to a separate 307 # TODO: Extract common mksnapshot_flags to a separate
299 # variable. 308 # variable.
300 'mksnapshot_flags_ignition': [ 309 'mksnapshot_flags_ignition': [
301 '--ignition', 310 '--ignition',
302 '--log-snapshot-positions', 311 '--log-snapshot-positions',
303 '--logfile', '<(INTERMEDIATE_DIR)/snapshot_ignition.log', 312 '--logfile', '<(INTERMEDIATE_DIR)/snapshot_ignition.log',
304 ], 313 ],
305 'conditions': [ 314 'conditions': [
306 ['v8_random_seed!=0', { 315 ['v8_random_seed!=0', {
307 'mksnapshot_flags_ignition': ['--random-seed', '<(v8_ran dom_seed)'], 316 'mksnapshot_flags_ignition': ['--random-seed', '<(v8_ran dom_seed)'],
308 }], 317 }],
309 ['v8_vector_stores!=0', { 318 ['v8_vector_stores!=0', {
310 'mksnapshot_flags_ignition': ['--vector-stores'], 319 'mksnapshot_flags_ignition': ['--vector-stores'],
311 }], 320 }],
312 ], 321 ],
313 }, 322 },
314 'outputs': [ 323 'conditions': [
315 '<(PRODUCT_DIR)/snapshot_blob_ignition.bin', 324 ['want_separate_host_toolset==1', {
316 ], 325 'target_conditions': [
317 'action': [ 326 ['_toolset=="host"', {
318 '<(mksnapshot_exec)', 327 'outputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition_hos t.bin'],
319 '<@(mksnapshot_flags_ignition)', 328 'action': [
320 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_ignition.bin ', 329 '<(mksnapshot_exec)',
321 '<(embed_script)', 330 '<@(mksnapshot_flags_ignition)',
331 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_igni tion_host.bin',
332 '<(embed_script)',
333 ],
334 }, {
335 'outputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition.bin '],
336 'action': [
337 '<(mksnapshot_exec)',
338 '<@(mksnapshot_flags_ignition)',
339 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_igni tion.bin',
340 '<(embed_script)',
341 ],
342 }],
343 ],
344 }, {
345 'outputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition.bin'],
346 'action': [
347 '<(mksnapshot_exec)',
348 '<@(mksnapshot_flags_ignition)',
349 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_ignition .bin',
350 '<(embed_script)',
351 ],
352 }],
322 ], 353 ],
323 }, 354 },
324 ], 355 ],
325 }], 356 }],
326 ], 357 ],
327 'dependencies': [ 358 'dependencies': [
328 'v8_base', 359 'v8_base',
329 ], 360 ],
330 'include_dirs+': [ 361 'include_dirs+': [
331 '../..', 362 '../..',
332 ], 363 ],
333 'sources': [ 364 'sources': [
334 '../../src/snapshot/natives-external.cc', 365 '../../src/snapshot/natives-external.cc',
335 '../../src/snapshot/snapshot-external.cc', 366 '../../src/snapshot/snapshot-external.cc',
336 ], 367 ],
337 'actions': [ 368 'actions': [
338 { 369 {
339 'action_name': 'run_mksnapshot (external)', 370 'action_name': 'run_mksnapshot (external)',
340 'inputs': [ 371 'inputs': ['<(mksnapshot_exec)'],
341 '<(mksnapshot_exec)',
342 ],
343 'variables': { 372 'variables': {
344 'mksnapshot_flags': [ 373 'mksnapshot_flags': [
345 '--log-snapshot-positions', 374 '--log-snapshot-positions',
346 '--logfile', '<(INTERMEDIATE_DIR)/snapshot.log', 375 '--logfile', '<(INTERMEDIATE_DIR)/snapshot.log',
347 ], 376 ],
348 'conditions': [ 377 'conditions': [
349 ['v8_random_seed!=0', { 378 ['v8_random_seed!=0', {
350 'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'], 379 'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],
351 }], 380 }],
352 ['v8_vector_stores!=0', { 381 ['v8_vector_stores!=0', {
353 'mksnapshot_flags': ['--vector-stores'], 382 'mksnapshot_flags': ['--vector-stores'],
354 }], 383 }],
355 ], 384 ],
356 }, 385 },
357 'conditions': [ 386 'conditions': [
358 ['want_separate_host_toolset==1', { 387 ['want_separate_host_toolset==1', {
359 'target_conditions': [ 388 'target_conditions': [
360 ['_toolset=="host"', { 389 ['_toolset=="host"', {
361 'outputs': [ 390 'outputs': ['<(PRODUCT_DIR)/snapshot_blob_host.bin'],
362 '<(PRODUCT_DIR)/snapshot_blob_host.bin',
363 ],
364 'action': [ 391 'action': [
365 '<(mksnapshot_exec)', 392 '<(mksnapshot_exec)',
366 '<@(mksnapshot_flags)', 393 '<@(mksnapshot_flags)',
367 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_host.bin ', 394 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_host.bin ',
368 '<(embed_script)', 395 '<(embed_script)',
369 ], 396 ],
370 }, { 397 }, {
371 'outputs': [ 398 'outputs': ['<(PRODUCT_DIR)/snapshot_blob.bin'],
372 '<(PRODUCT_DIR)/snapshot_blob.bin',
373 ],
374 'action': [ 399 'action': [
375 '<(mksnapshot_exec)', 400 '<(mksnapshot_exec)',
376 '<@(mksnapshot_flags)', 401 '<@(mksnapshot_flags)',
377 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob.bin', 402 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob.bin',
378 '<(embed_script)', 403 '<(embed_script)',
379 ], 404 ],
380 }], 405 }],
381 ], 406 ],
382 }, { 407 }, {
383 'outputs': [ 408 'outputs': ['<(PRODUCT_DIR)/snapshot_blob.bin'],
384 '<(PRODUCT_DIR)/snapshot_blob.bin',
385 ],
386 'action': [ 409 'action': [
387 '<(mksnapshot_exec)', 410 '<(mksnapshot_exec)',
388 '<@(mksnapshot_flags)', 411 '<@(mksnapshot_flags)',
389 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob.bin', 412 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob.bin',
390 '<(embed_script)', 413 '<(embed_script)',
391 ], 414 ],
392 }], 415 }],
393 ], 416 ],
394 }, 417 },
395 ], 418 ],
(...skipping 1786 matching lines...) Expand 10 before | Expand all | Expand 10 after
2182 }], 2205 }],
2183 ['want_separate_host_toolset==1', { 2206 ['want_separate_host_toolset==1', {
2184 'toolsets': ['host'], 2207 'toolsets': ['host'],
2185 }, { 2208 }, {
2186 'toolsets': ['target'], 2209 'toolsets': ['target'],
2187 }], 2210 }],
2188 ], 2211 ],
2189 }, 2212 },
2190 ], 2213 ],
2191 } 2214 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698