Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: tools/gyp/v8.gyp

Issue 1684543002: [Ignition] Fix separate ignition snapshot for separate toolsets. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index 1f6cf13a960b30c2d84a618e3353adc0aa2a7b0f..5951a0c6a795de55e065adb98751fb461b1848ce 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -120,18 +120,30 @@
}],
['v8_use_snapshot=="true" and v8_use_external_startup_data==1 and want_separate_host_toolset==0', {
'dependencies': ['v8_base', 'v8_external_snapshot'],
- 'inputs': [ '<(PRODUCT_DIR)/snapshot_blob.bin', ],
+ 'inputs': ['<(PRODUCT_DIR)/snapshot_blob.bin'],
+ 'conditions': [
+ ['v8_separate_ignition_snapshot==1', {
+ 'inputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition.bin'],
+ }],
+ ]
}],
['v8_use_snapshot=="true" and v8_use_external_startup_data==1 and want_separate_host_toolset==1', {
'dependencies': ['v8_base', 'v8_external_snapshot'],
'target_conditions': [
['_toolset=="host"', {
- 'inputs': [
- '<(PRODUCT_DIR)/snapshot_blob_host.bin',
- ],
+ 'inputs': ['<(PRODUCT_DIR)/snapshot_blob_host.bin'],
}, {
- 'inputs': [
- '<(PRODUCT_DIR)/snapshot_blob.bin',
+ 'inputs': ['<(PRODUCT_DIR)/snapshot_blob.bin'],
+ }],
+ ],
+ 'conditions': [
+ ['v8_separate_ignition_snapshot==1', {
+ 'target_conditions': [
+ ['_toolset=="host"', {
+ 'inputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition_host.bin'],
+ }, {
+ 'inputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition.bin'],
+ }],
],
}],
],
@@ -283,17 +295,14 @@
],
},
}],
- # Extra snapshot blob for ignition. Separate host toolset is not
- # supported.
+ # Extra snapshot blob for ignition.
['v8_separate_ignition_snapshot==1', {
# This is concatenated to the other actions list of
# v8_external_snapshot.
'actions': [
{
'action_name': 'run_mksnapshot (ignition)',
- 'inputs': [
- '<(mksnapshot_exec)',
- ],
+ 'inputs': ['<(mksnapshot_exec)'],
'variables': {
# TODO: Extract common mksnapshot_flags to a separate
# variable.
@@ -311,14 +320,36 @@
}],
],
},
- 'outputs': [
- '<(PRODUCT_DIR)/snapshot_blob_ignition.bin',
- ],
- 'action': [
- '<(mksnapshot_exec)',
- '<@(mksnapshot_flags_ignition)',
- '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_ignition.bin',
- '<(embed_script)',
+ 'conditions': [
+ ['want_separate_host_toolset==1', {
+ 'target_conditions': [
+ ['_toolset=="host"', {
+ 'outputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition_host.bin'],
+ 'action': [
+ '<(mksnapshot_exec)',
+ '<@(mksnapshot_flags_ignition)',
+ '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_ignition_host.bin',
+ '<(embed_script)',
+ ],
+ }, {
+ 'outputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition.bin'],
+ 'action': [
+ '<(mksnapshot_exec)',
+ '<@(mksnapshot_flags_ignition)',
+ '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_ignition.bin',
+ '<(embed_script)',
+ ],
+ }],
+ ],
+ }, {
+ 'outputs': ['<(PRODUCT_DIR)/snapshot_blob_ignition.bin'],
+ 'action': [
+ '<(mksnapshot_exec)',
+ '<@(mksnapshot_flags_ignition)',
+ '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_ignition.bin',
+ '<(embed_script)',
+ ],
+ }],
],
},
],
@@ -337,9 +368,7 @@
'actions': [
{
'action_name': 'run_mksnapshot (external)',
- 'inputs': [
- '<(mksnapshot_exec)',
- ],
+ 'inputs': ['<(mksnapshot_exec)'],
'variables': {
'mksnapshot_flags': [
'--log-snapshot-positions',
@@ -358,9 +387,7 @@
['want_separate_host_toolset==1', {
'target_conditions': [
['_toolset=="host"', {
- 'outputs': [
- '<(PRODUCT_DIR)/snapshot_blob_host.bin',
- ],
+ 'outputs': ['<(PRODUCT_DIR)/snapshot_blob_host.bin'],
'action': [
'<(mksnapshot_exec)',
'<@(mksnapshot_flags)',
@@ -368,9 +395,7 @@
'<(embed_script)',
],
}, {
- 'outputs': [
- '<(PRODUCT_DIR)/snapshot_blob.bin',
- ],
+ 'outputs': ['<(PRODUCT_DIR)/snapshot_blob.bin'],
'action': [
'<(mksnapshot_exec)',
'<@(mksnapshot_flags)',
@@ -380,9 +405,7 @@
}],
],
}, {
- 'outputs': [
- '<(PRODUCT_DIR)/snapshot_blob.bin',
- ],
+ 'outputs': ['<(PRODUCT_DIR)/snapshot_blob.bin'],
'action': [
'<(mksnapshot_exec)',
'<@(mksnapshot_flags)',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698