Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1684353002: QUIC - check for null stream_ before calling stream_'s IsDoneReading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « net/quic/quic_http_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index ba90135b713fcc1779b6921b501b8c09ecdcce27..94c92a35397b4ffea3acd0d7cff665310ffc8afd 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -26018,6 +26018,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Net.QuicReadAvailableData.NullStream" enum="BooleanNullStream">
+ <owner>rtenneti@chromium.org</owner>
+ <summary>
+ The number of times QuicHttpStream's stream_ is a nullptr before
+ IsDoneReading() is called.
+ </summary>
+</histogram>
+
<histogram name="Net.QuicServerInfo.DiskCacheLoadTime" units="ms">
<owner>rtenneti@chromium.org</owner>
<summary>Time spent to load QUIC server information from disk cache.</summary>
@@ -58793,6 +58801,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="1" label="Missing data in disk cache"/>
</enum>
+<enum name="BooleanNullStream" type="int">
+ <int value="0" label="Stream is not a nullptr"/>
+ <int value="1" label="Stream is a nullptr"/>
+</enum>
+
<enum name="BooleanNullVisitor" type="int">
<int value="0" label="Connection's visitor is not a nullptr"/>
<int value="1" label="Connection's visitor is a nullptr"/>
« no previous file with comments | « net/quic/quic_http_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698