Upgrade TexSubImage3D and TexStorage3D.

Upgrade TexSubImage3D and TexStorage3D.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ec8cab4d9895568bb2c682556efdcc3aa08ab818
Cr-Commit-Position: refs/heads/master@{#375752}

[Zhenyao Mo, 2016-02-11 00:54:29]

Description was changed from

==========
Upgrade TexSubImage3D and TexStorage3D.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
==========

to

==========
Upgrade TexSubImage3D and TexStorage3D.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-02-11 00:56:18]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-11 00:56:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684343002/1

[Zhenyao Mo, 2016-02-11 00:57:49]

piman: PTAL
Others: FYI

Unfortunately TexSubImage3D has 11 args and gmock only supports up to 10 at the
moment. So I can't write unit tests for TexSubImage3D.  We will depend on WebGL
conformance tests.

[Ken Russell (switch to Gerrit), 2016-02-11 01:30:16]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-02-11 01:30:17]

This LGTM but I'm not an owner. One question.

https://codereview.chromium.org/1684343002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/1684343002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:2226: // TODO(zmo): Upgrade to 3D.
What will happen here if this code path is taken for a 3D texture?

Should this TODO reference a bug ID?

[piman, 2016-02-11 02:00:22]

https://codereview.chromium.org/1684343002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/1684343002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:2226: // TODO(zmo): Upgrade to 3D.
On 2016/02/11 01:30:17, Ken Russell wrote:
> What will happen here if this code path is taken for a 3D texture?
> 
> Should this TODO reference a bug ID?

Yeah, the clearing logic is incomplete for 3D:
- only keeping a cleared rect is not enough - you need a cleared box (or punt on
combining for 3D and always clear if not writing to the whole level image)
- GLES2DecoderImpl::ClearLevel only clears 2D, and would fail on 3D textures.
- the logic in TextureAttachment::SetCleared marks the whole level as cleared
even though a single layer was.

[commit-bot: I haz the power, 2016-02-11 02:15:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-11 02:15:16]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-02-16 20:20:14]

Patchset #2 (id:20001) has been deleted

[Zhenyao Mo, 2016-02-16 21:53:37]

Per discussion with reveman, we can't simplify the clear logic.  Compositor
depends on the current behavior for the perf.

So in this CL, I simply mark all 3D textures as cleared (it's a lie if data is
null), and will implement the clearing in a separate CL as it is not trivia.

(Another case to create an uninitialized texture is TexStorage3D, but that's not
fully implemented yet).

[Zhenyao Mo, 2016-02-16 21:53:44]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-02-16 21:54:50]

piman: I create a bug to track the clearing of 3D textures. Can you review this
CL? Right now since I always mark 3D textures as cleared at TexImage3D time, we
won't trigger the Clear path that does not support 3D textures.

[commit-bot: I haz the power, 2016-02-16 21:55:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684343002/60001

[piman, 2016-02-16 23:41:34]

LGTM. Could you also add a DCHECK in GLES2DecoderImpl::ClearLevel that the
target is not GL_TEXTURE_3D (with the same TODO)?

[commit-bot: I haz the power, 2016-02-16 23:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 23:49:21]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-02-16 23:57:30]

Patchset #4 (id:80001) has been deleted

[Zhenyao Mo, 2016-02-16 23:57:49]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-02-16 23:57:49]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1684343002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-02-16 23:59:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684343002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684343002/100001

[Zhenyao Mo, 2016-02-17 00:30:52]

The CQ bit was unchecked by zmo@chromium.org

[Zhenyao Mo, 2016-02-17 00:38:17]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-02-17 00:38:17]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1684343002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-02-17 00:39:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684343002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684343002/120001

[commit-bot: I haz the power, 2016-02-17 02:07:34]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-02-17 02:08:34]

Description was changed from

==========
Upgrade TexSubImage3D and TexStorage3D.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Upgrade TexSubImage3D and TexStorage3D.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ec8cab4d9895568bb2c682556efdcc3aa08ab818
Cr-Commit-Position: refs/heads/master@{#375752}
==========

[commit-bot: I haz the power, 2016-02-17 02:08:35]

Patchset 5 (id:??) landed as
https://crrev.com/ec8cab4d9895568bb2c682556efdcc3aa08ab818
Cr-Commit-Position: refs/heads/master@{#375752}