Mark null and undefined as undetectable, and use it to handle abstract equality comparison in the g…

Mark null and undefined as undetectable, and use it to handle abstract equality comparison in the generic compare ic

Marking as undetectable makes abstract equality of null, undefined, and
other undetectable objects easier. Supporting it in the generic compare
IC significantly speeds up dynamic comparison between those values and
JSReceivers by not falling back to the runtime.

MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com>;

Committed: https://crrev.com/3ce9e808c5b9a6149ac987213854b5d59005f366
Cr-Commit-Position: refs/heads/master@{#33858}

[Toon Verwaest, 2016-02-09 09:26:28]

ptal. This speeds up the minified Richards test provided by Stephen Adams by
~20%, greatly reducing the performance difference with the non-minified version.

[Benedikt Meurer, 2016-02-09 10:25:17]

Nice, thanks for doing this. LGTM.

[Toon Verwaest, 2016-02-09 10:42:10]

verwaest@chromium.org changed reviewers:
+ v8-mips-ports@googlegroups.com, v8-ppc-ports@googlegroups.com

[Toon Verwaest, 2016-02-09 10:42:10]

MIPS-ports, could you please port to MIPS?

[Toon Verwaest, 2016-02-09 10:47:06]

verwaest@chromium.org changed reviewers:
+ ulan@chromium.org

[Toon Verwaest, 2016-02-09 10:47:07]

ulan: ptal at heap.cc

[ulan, 2016-02-09 10:48:08]

heap lgtm

[Toon Verwaest, 2016-02-09 11:54:47]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 11:54:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683643002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683643002/100001

[commit-bot: I haz the power, 2016-02-09 12:11:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 12:11:55]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[Toon Verwaest, 2016-02-09 12:24:32]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 12:24:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683643002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683643002/120001

[commit-bot: I haz the power, 2016-02-09 12:48:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 12:48:22]

Dry run: This issue passed the CQ dry run.

[balazs.kilvady, 2016-02-09 19:58:46]

On 2016/02/09 10:42:10, Toon Verwaest wrote:
> MIPS-ports, could you please port to MIPS?

Please find (and merge :) ) the MIPS port at
https://codereview.chromium.org/1681273002/

[Toon Verwaest, 2016-02-10 09:25:38]

Description was changed from

==========
Mark null and undefined as undetectable, and use it to handle abstract equality
comparison in the generic compare ic

Marking as undetectable makes abstract equality of null, undefined, and
other undetectable objects easier. Supporting it in the generic compare
IC significantly speeds up dynamic comparison between those values and
JSReceivers by not falling back to the runtime.

R=bmeurer@chromium.org
==========

to

==========
Mark null and undefined as undetectable, and use it to handle abstract equality
comparison in the generic compare ic

Marking as undetectable makes abstract equality of null, undefined, and
other undetectable objects easier. Supporting it in the generic compare
IC significantly speeds up dynamic comparison between those values and
JSReceivers by not falling back to the runtime.

MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com>
==========

[Toon Verwaest, 2016-02-10 09:26:30]

Thanks, I integrated them.

[Toon Verwaest, 2016-02-10 09:26:41]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-02-10 09:26:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1683643002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-02-10 09:26:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683643002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683643002/140001

[commit-bot: I haz the power, 2016-02-10 09:55:54]

Description was changed from

==========
Mark null and undefined as undetectable, and use it to handle abstract equality
comparison in the generic compare ic

Marking as undetectable makes abstract equality of null, undefined, and
other undetectable objects easier. Supporting it in the generic compare
IC significantly speeds up dynamic comparison between those values and
JSReceivers by not falling back to the runtime.

MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com>
==========

to

==========
Mark null and undefined as undetectable, and use it to handle abstract equality
comparison in the generic compare ic

Marking as undetectable makes abstract equality of null, undefined, and
other undetectable objects easier. Supporting it in the generic compare
IC significantly speeds up dynamic comparison between those values and
JSReceivers by not falling back to the runtime.

MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com>
==========

[commit-bot: I haz the power, 2016-02-10 09:55:55]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-02-10 09:56:36]

Description was changed from

==========
Mark null and undefined as undetectable, and use it to handle abstract equality
comparison in the generic compare ic

Marking as undetectable makes abstract equality of null, undefined, and
other undetectable objects easier. Supporting it in the generic compare
IC significantly speeds up dynamic comparison between those values and
JSReceivers by not falling back to the runtime.

MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com>
==========

to

==========
Mark null and undefined as undetectable, and use it to handle abstract equality
comparison in the generic compare ic

Marking as undetectable makes abstract equality of null, undefined, and
other undetectable objects easier. Supporting it in the generic compare
IC significantly speeds up dynamic comparison between those values and
JSReceivers by not falling back to the runtime.

MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com>

Committed: https://crrev.com/3ce9e808c5b9a6149ac987213854b5d59005f366
Cr-Commit-Position: refs/heads/master@{#33858}
==========

[commit-bot: I haz the power, 2016-02-10 09:56:38]

Patchset 8 (id:??) landed as
https://crrev.com/3ce9e808c5b9a6149ac987213854b5d59005f366
Cr-Commit-Position: refs/heads/master@{#33858}