Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: src/crankshaft/mips/lithium-codegen-mips.cc

Issue 1683643002: Mark null and undefined as undetectable, and use it to handle abstract equality comparison in the g… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved.7 1 // Copyright 2012 the V8 project authors. All rights reserved.7
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5234 matching lines...) Expand 10 before | Expand all | Expand 10 after
5245 5245
5246 } else if (String::Equals(type_name, factory->boolean_string())) { 5246 } else if (String::Equals(type_name, factory->boolean_string())) {
5247 __ LoadRoot(at, Heap::kTrueValueRootIndex); 5247 __ LoadRoot(at, Heap::kTrueValueRootIndex);
5248 __ Branch(USE_DELAY_SLOT, true_label, eq, at, Operand(input)); 5248 __ Branch(USE_DELAY_SLOT, true_label, eq, at, Operand(input));
5249 __ LoadRoot(at, Heap::kFalseValueRootIndex); 5249 __ LoadRoot(at, Heap::kFalseValueRootIndex);
5250 *cmp1 = at; 5250 *cmp1 = at;
5251 *cmp2 = Operand(input); 5251 *cmp2 = Operand(input);
5252 final_branch_condition = eq; 5252 final_branch_condition = eq;
5253 5253
5254 } else if (String::Equals(type_name, factory->undefined_string())) { 5254 } else if (String::Equals(type_name, factory->undefined_string())) {
5255 __ LoadRoot(at, Heap::kUndefinedValueRootIndex); 5255 __ LoadRoot(at, Heap::kNullValueRootIndex);
5256 __ Branch(USE_DELAY_SLOT, true_label, eq, at, Operand(input)); 5256 __ Branch(USE_DELAY_SLOT, false_label, eq, at, Operand(input));
5257 // The first instruction of JumpIfSmi is an And - it is safe in the delay 5257 // The first instruction of JumpIfSmi is an And - it is safe in the delay
5258 // slot. 5258 // slot.
5259 __ JumpIfSmi(input, false_label); 5259 __ JumpIfSmi(input, false_label);
5260 // Check for undetectable objects => true. 5260 // Check for undetectable objects => true.
5261 __ lw(input, FieldMemOperand(input, HeapObject::kMapOffset)); 5261 __ lw(input, FieldMemOperand(input, HeapObject::kMapOffset));
5262 __ lbu(at, FieldMemOperand(input, Map::kBitFieldOffset)); 5262 __ lbu(at, FieldMemOperand(input, Map::kBitFieldOffset));
5263 __ And(at, at, 1 << Map::kIsUndetectable); 5263 __ And(at, at, 1 << Map::kIsUndetectable);
5264 *cmp1 = at; 5264 *cmp1 = at;
5265 *cmp2 = Operand(zero_reg); 5265 *cmp2 = Operand(zero_reg);
5266 final_branch_condition = ne; 5266 final_branch_condition = ne;
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
5572 __ Push(at, ToRegister(instr->function())); 5572 __ Push(at, ToRegister(instr->function()));
5573 CallRuntime(Runtime::kPushBlockContext, instr); 5573 CallRuntime(Runtime::kPushBlockContext, instr);
5574 RecordSafepoint(Safepoint::kNoLazyDeopt); 5574 RecordSafepoint(Safepoint::kNoLazyDeopt);
5575 } 5575 }
5576 5576
5577 5577
5578 #undef __ 5578 #undef __
5579 5579
5580 } // namespace internal 5580 } // namespace internal
5581 } // namespace v8 5581 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/ia32/lithium-codegen-ia32.cc ('k') | src/crankshaft/mips64/lithium-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698