src/heap/heap.cc - Issue 1683643002: Mark null and undefined as undetectable, and use it to handle abstract equality comparison in the g…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1683643002: Mark null and undefined as undetectable, and use it to handle abstract equality comparison in the g… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index f40fe4b958d42afe3ad05ad12af7cfc25a4b8fe9..44c59a20b69cd6c4b8d5a8a8f6dbbcc12d94f186 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -2258,6 +2258,7 @@ bool Heap::CreateInitialMaps() {

if (FLAG_unbox_double_fields) {

null_map()->set_layout_descriptor(LayoutDescriptor::FastPointerLayout());

}

+ null_map()->set_is_undetectable();

// Fix prototype object for existing maps.

meta_map()->set_prototype(null_value());

@@ -2268,6 +2269,7 @@ bool Heap::CreateInitialMaps() {

undefined_map()->set_prototype(null_value());

undefined_map()->set_constructor_or_backpointer(null_value());

+ undefined_map()->set_is_undetectable();

null_map()->set_prototype(null_value());

null_map()->set_constructor_or_backpointer(null_value());

« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »