Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1682893002: Color the ink drop ripple and hover effects based on theming. (Closed)

Created:
4 years, 10 months ago by Evan Stade
Modified:
4 years, 9 months ago
Reviewers:
sadrul, bruthig
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Color the ink drop ripple and hover effects based on theming. Depends on crrev.com/1660123002 BUG=575789

Patch Set 1 #

Patch Set 2 : self review #

Patch Set 3 : fix unit tests #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -71 lines) Patch
M chrome/browser/ui/views/bar_control_button.cc View 1 chunk +1 line, -0 lines 3 comments Download
M chrome/browser/ui/views/location_bar/bubble_icon_view.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/bubble_icon_view.cc View 2 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/reload_button.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/ink_drop_animation_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_factory.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.h View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.cc View 6 chunks +21 lines, -19 lines 2 comments Download
M ui/views/animation/ink_drop_animation_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/animation/ink_drop_host.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_hover.h View 3 chunks +5 lines, -1 line 0 comments Download
M ui/views/animation/ink_drop_hover.cc View 1 2 chunks +9 lines, -6 lines 3 comments Download
M ui/views/animation/ink_drop_hover_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/animation/square_ink_drop_animation.h View 1 chunk +5 lines, -1 line 0 comments Download
M ui/views/animation/square_ink_drop_animation.cc View 1 4 chunks +8 lines, -7 lines 0 comments Download
M ui/views/animation/square_ink_drop_animation_unittest.cc View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_host.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_host.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Evan Stade
https://codereview.chromium.org/1682893002/diff/40001/ui/views/animation/ink_drop_hover.cc File ui/views/animation/ink_drop_hover.cc (left): https://codereview.chromium.org/1682893002/diff/40001/ui/views/animation/ink_drop_hover.cc#oldcode19 ui/views/animation/ink_drop_hover.cc:19: const float kHoverVisibleOpacity = 0.08f; I used algebra for ...
4 years, 10 months ago (2016-02-09 20:39:28 UTC) #3
bruthig
https://codereview.chromium.org/1682893002/diff/40001/chrome/browser/ui/views/bar_control_button.cc File chrome/browser/ui/views/bar_control_button.cc (right): https://codereview.chromium.org/1682893002/diff/40001/chrome/browser/ui/views/bar_control_button.cc#newcode58 chrome/browser/ui/views/bar_control_button.cc:58: set_ink_drop_base_color(icon_color); Shouldn't some of the other Views use a ...
4 years, 10 months ago (2016-02-09 21:01:06 UTC) #4
Evan Stade
https://codereview.chromium.org/1682893002/diff/40001/chrome/browser/ui/views/bar_control_button.cc File chrome/browser/ui/views/bar_control_button.cc (right): https://codereview.chromium.org/1682893002/diff/40001/chrome/browser/ui/views/bar_control_button.cc#newcode58 chrome/browser/ui/views/bar_control_button.cc:58: set_ink_drop_base_color(icon_color); On 2016/02/09 21:01:06, bruthig wrote: > Shouldn't some ...
4 years, 10 months ago (2016-02-09 22:54:28 UTC) #5
bruthig
LGTM https://codereview.chromium.org/1682893002/diff/40001/chrome/browser/ui/views/bar_control_button.cc File chrome/browser/ui/views/bar_control_button.cc (right): https://codereview.chromium.org/1682893002/diff/40001/chrome/browser/ui/views/bar_control_button.cc#newcode58 chrome/browser/ui/views/bar_control_button.cc:58: set_ink_drop_base_color(icon_color); On 2016/02/09 22:54:28, Evan Stade wrote: > ...
4 years, 10 months ago (2016-02-10 15:09:54 UTC) #6
sadrul
lgtm https://codereview.chromium.org/1682893002/diff/40001/ui/views/animation/ink_drop_animation_controller_impl.cc File ui/views/animation/ink_drop_animation_controller_impl.cc (right): https://codereview.chromium.org/1682893002/diff/40001/ui/views/animation/ink_drop_animation_controller_impl.cc#newcode124 ui/views/animation/ink_drop_animation_controller_impl.cc:124: CHECK(!hover_); D versions?
4 years, 10 months ago (2016-02-10 23:26:50 UTC) #7
Evan Stade
thanks. I will wait till bruthig's patch lands, rebase, and if there are no substantive ...
4 years, 10 months ago (2016-02-11 00:13:26 UTC) #8
bruthig
4 years, 10 months ago (2016-02-18 20:25:04 UTC) #9 
I just realized that an InkDropAnimationControllerImpl instance will only ever
create an InkDropHover once. i.e. it never destroys an old instance.  Can you
try the following to double check?

1. Start Chrome with MD on
2. Mouse over the Home button.
3. Mouse off the Home button.
3. Switch themes, or cause the ink drop base color to change.
4. Mouse over the Home button.

I suspect the Home button will have the original color and won't be updated.

Powered by Google App Engine
This is Rietveld 408576698