chrome/browser/ui/views/location_bar/bubble_icon_view.h - Issue 1682893002: Color the ink drop ripple and hover effects based on theming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.h

Issue 1682893002: Color the ink drop ripple and hover effects based on theming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/bar_control_button.cc ('K') | « chrome/browser/ui/views/bar_control_button.cc ('k') | chrome/browser/ui/views/location_bar/bubble_icon_view.cc » ('j') | ui/views/animation/ink_drop_animation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/bubble_icon_view.h

diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.h b/chrome/browser/ui/views/location_bar/bubble_icon_view.h

index db1ef23df430ab4a991b305dbec424682e7ab8ef..5f7eec83ac4a1ff936736743ba3574ed8053c93a 100644

--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.h

+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.h

@@ -73,6 +73,9 @@ class BubbleIconView : public views::View,

// views::InkDropHost:

void AddInkDropLayer(ui::Layer* ink_drop_layer) override;

void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;

+ gfx::Point CalculateInkDropCenter() const override;

+ bool ShouldShowInkDropHover() const override;

+ SkColor GetInkDropBaseColor() const override;

// views::WidgetObserver:

void OnWidgetDestroying(views::Widget* widget) override;

@@ -98,10 +101,6 @@ class BubbleIconView : public views::View,

// views::View:

void OnBoundsChanged(const gfx::Rect& previous_bounds) override;

- // views::InkDropHost:

- gfx::Point CalculateInkDropCenter() const override;

- bool ShouldShowInkDropHover() const override;

// Updates the icon after some state has changed.

void UpdateIcon();