chrome/browser/ui/views/bar_control_button.cc - Issue 1682893002: Color the ink drop ripple and hover effects based on theming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bar_control_button.cc

Issue 1682893002: Color the ink drop ripple and hover effects based on theming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/bar_control_button.cc

diff --git a/chrome/browser/ui/views/bar_control_button.cc b/chrome/browser/ui/views/bar_control_button.cc

index cb76a42538f7117dd7876e76e26b4d185b5403a3..93e0d7001397f563b08d4d1397b86af7e094966f 100644

--- a/chrome/browser/ui/views/bar_control_button.cc

+++ b/chrome/browser/ui/views/bar_control_button.cc

@@ -55,6 +55,7 @@ void BarControlButton::OnThemeChanged() {

SetImage(views::CustomButton::STATE_NORMAL, &image);

image = gfx::CreateVectorIcon(id_, 16, SkColorSetA(icon_color, 0xff / 2));

SetImage(views::CustomButton::STATE_DISABLED, &image);

+ set_ink_drop_base_color(icon_color);

bruthig 2016/02/09 21:01:06 Shouldn't some of the other Views use a similar pa

Evan Stade 2016/02/09 22:54:28 like which one?

bruthig 2016/02/10 15:09:54 Nevermind, I follow now.

}

void BarControlButton::OnNativeThemeChanged(const ui::NativeTheme* theme) {

« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/bubble_icon_view.h » ('j') | ui/views/animation/ink_drop_animation_controller_impl.cc » ('J')