Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1693583003: Undo the parameterization of SiteDetailsBrowserTest. ManyIframes/2 times out on Mac. (Closed)

Created:
4 years, 10 months ago by ncarter (slow)
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@uma3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Undo the parameterization of SiteDetailsBrowserTest. ManyIframes/2 times out on Mac. We'll just keep using the FYI bots for coverage. BUG=586041 TEST=browser_tests with and without --site-per-process Committed: https://crrev.com/eac6998792e0478a7b095d1db6294c36ad917cd9 Cr-Commit-Position: refs/heads/master@{#375018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M chrome/browser/site_details_browsertest.cc View 9 chunks +8 lines, -24 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
ncarter (slow)
4 years, 10 months ago (2016-02-11 18:36:16 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-11 21:24:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693583003/1
4 years, 10 months ago (2016-02-11 21:34:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 22:19:03 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:38:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eac6998792e0478a7b095d1db6294c36ad917cd9
Cr-Commit-Position: refs/heads/master@{#375018}

Powered by Google App Engine
This is Rietveld 408576698