Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: mojo/gles2/command_buffer_client_impl.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/gles2/command_buffer_client_impl.cc
diff --git a/mojo/gles2/command_buffer_client_impl.cc b/mojo/gles2/command_buffer_client_impl.cc
index bda36a6bf3f3d7e46501455d3914f59a46860d5d..ca8e43b91f769982e87169102f7167a56fd8c64d 100644
--- a/mojo/gles2/command_buffer_client_impl.cc
+++ b/mojo/gles2/command_buffer_client_impl.cc
@@ -152,10 +152,9 @@ bool CommandBufferClientImpl::Initialize() {
mojo::CommandBufferLostContextObserverPtr observer_ptr;
observer_binding_.Bind(GetProxy(&observer_ptr), async_waiter_);
- command_buffer_->Initialize(sync_client.Pass(),
- sync_point_client.Pass(),
- observer_ptr.Pass(),
- duped.Pass());
+ command_buffer_->Initialize(sync_client.PassInterfaceHandle(),
viettrungluu 2016/02/10 01:04:08 This seems suspicious to me. I wonder if the vario
vardhan 2016/02/11 22:47:53 Done. (I had mojo::Binding<> accept InterfaceHand
+ sync_point_client.PassInterfaceHandle(),
+ observer_ptr.PassInterfaceHandle(), duped.Pass());
viettrungluu 2016/02/10 01:04:08 And what I said about GetProxy applies here to obs
vardhan 2016/02/11 22:47:53 Done.
// Wait for DidInitialize to come on the sync client pipe.
if (!sync_client_impl_->WaitForInitialization()) {

Powered by Google App Engine
This is Rietveld 408576698