examples/spinning_cube/spinning_cube_app.cc - Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: examples/spinning_cube/spinning_cube_app.cc

Issue 1682113003: Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« examples/native_run_app/native_run_app.cc ('K') | « examples/spinning_cube/gles2_client_impl.cc ('k') | mojo/common/trace_provider_impl.h » ('j') | mojo/gles2/command_buffer_client_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: examples/spinning_cube/spinning_cube_app.cc

diff --git a/examples/spinning_cube/spinning_cube_app.cc b/examples/spinning_cube/spinning_cube_app.cc

index f90f9d1c28f3353c9fd8d5b5cfc6b444365919c6..c8b477a07f4531cfe78949a28f608e94efd52c47 100644

--- a/examples/spinning_cube/spinning_cube_app.cc

+++ b/examples/spinning_cube/spinning_cube_app.cc

@@ -77,7 +77,7 @@ class SpinningCubeApp : public mojo::ApplicationDelegate,

void SetEventDispatcher() {

mojo::NativeViewportEventDispatcherPtr ptr;

dispatcher_binding_.Bind(GetProxy(&ptr));

- viewport_->SetEventDispatcher(ptr.Pass());

+ viewport_->SetEventDispatcher(ptr.PassInterfaceHandle());

viettrungluu 2016/02/10 01:04:08 So, this seems kind of dumb: GetProxy() makes a m

vardhan 2016/02/11 22:47:53 Done.

}

void OnViewportConnectionError() { mojo::RunLoop::current()->Quit(); }