Mojo C++ bindings: Generate InterfaceHandle<> instead of InterfacePtr<>.

mojo/gles2/command_buffer_client_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/gles2/command_buffer_client_impl.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "base/process/process_handle.h"
@@ skipping 134 matching lines @@
 
   mojo::CommandBufferSyncClientPtr sync_client;
   sync_client_impl_.reset(new SyncClientImpl(&sync_client, async_waiter_));
 
   mojo::CommandBufferSyncPointClientPtr sync_point_client;
   sync_point_client_impl_.reset(
       new SyncPointClientImpl(&sync_point_client, async_waiter_));
 
   mojo::CommandBufferLostContextObserverPtr observer_ptr;
   observer_binding_.Bind(GetProxy(&observer_ptr), async_waiter_);
-  command_buffer_->Initialize(sync_client.Pass(),
-                              sync_point_client.Pass(),
-                              observer_ptr.Pass(),
-                              duped.Pass());
+  command_buffer_->Initialize(sync_client.PassInterfaceHandle(),

[viettrungluu, 2016/02/10 01:04:08]

This seems suspicious to me. I wonder if the various ctors above shouldn't take
InterfaceHandle<T>*s instead.

[vardhan, 2016/02/11 22:47:53]

Done.  (I had mojo::Binding<> accept InterfaceHandle*, and added a note to try
and deprecate accepting an InterfacePtr* instead)

+                              sync_point_client.PassInterfaceHandle(),
+                              observer_ptr.PassInterfaceHandle(), duped.Pass());

[viettrungluu, 2016/02/10 01:04:08]

And what I said about GetProxy applies here to observer_ptr too.

[vardhan, 2016/02/11 22:47:53]

Done.

 
   // Wait for DidInitialize to come on the sync client pipe.
   if (!sync_client_impl_->WaitForInitialization()) {
     VLOG(1) << "Channel encountered error while creating command buffer";
     return false;
   }
   capabilities_ = sync_client_impl_->GetCapabilities();
   return true;
 }
 
@@ skipping 157 matching lines @@
   }
 
   if (state->generation - last_state_.generation < 0x80000000U)
     last_state_ = state.To<State>();
 }
 
 void CommandBufferClientImpl::SetLock(base::Lock* lock) {
 }
 
 }  // namespace gles2