Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168203003: NetworkStats: fix use after free. Don't call socket_->Read if tests are (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

NetworkStats: fix use after free. Don't call socket_->Read if tests are done. R=jar@chromium.org BUG=342395 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252811

Patch Set 1 #

Patch Set 2 : handle random packet being received before the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/browser/net/network_stats.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/net/network_stats.cc View 1 6 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ramant (doing other things)
6 years, 10 months ago (2014-02-19 17:59:59 UTC) #1
ramant (doing other things)
Hi Jim, Verified all unit tests pass with the latest changes. As we had discussed, ...
6 years, 10 months ago (2014-02-20 22:21:15 UTC) #2
jar (doing other things)
lgtm
6 years, 10 months ago (2014-02-22 01:54:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/168203003/250001
6 years, 10 months ago (2014-02-22 01:55:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 03:40:12 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268397
6 years, 10 months ago (2014-02-22 03:40:12 UTC) #6
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 10 months ago (2014-02-22 07:10:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/168203003/250001
6 years, 10 months ago (2014-02-22 07:11:08 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 18:57:00 UTC) #9
Message was sent while issue was closed. 
Change committed as 252811

Powered by Google App Engine
This is Rietveld 408576698