Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2036)

Unified Diff: chrome/browser/net/network_stats.h

Issue 168203003: NetworkStats: fix use after free. Don't call socket_->Read if tests are (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: handle random packet being received before the test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/net/network_stats.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/network_stats.h
diff --git a/chrome/browser/net/network_stats.h b/chrome/browser/net/network_stats.h
index 562eb759bf763d120b5f2b075d20578f50a00339..ff17df573a1943672567906c24d26f8325042c14 100644
--- a/chrome/browser/net/network_stats.h
+++ b/chrome/browser/net/network_stats.h
@@ -181,8 +181,9 @@ class NetworkStats {
// Collect network connectivity stats. This is called when all the data from
// server is read or when there is a failure during connect/read/write. It
// will either start the next phase of the test, or it will self destruct
- // at the end of this method.
- void TestPhaseComplete(Status status, int result);
+ // at the end of this method. Returns true if a new test wasn't started and it
+ // was self destructed.
+ bool TestPhaseComplete(Status status, int result);
// This method is called from TestPhaseComplete() and calls
// |finished_callback_| callback to indicate that the test has finished.
« no previous file with comments | « no previous file | chrome/browser/net/network_stats.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698