NetworkStats: fix use after free. Don't call socket_->Read if tests are

chrome/browser/net/network_stats.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_NETWORK_STATS_H_
 #define CHROME_BROWSER_NET_NETWORK_STATS_H_
 
 #include <bitset>
 #include <string>
 #include <vector>
@@ skipping 163 matching lines @@
 
   // Called when the StartReadDataTimer fires. |test_index| specifies
   // the index of the test. If |current_test_index_| has changed to a
   // different value, it indicates |test_index| has completed, then
   // this method is a no-op.
   void OnReadDataTimeout(uint32 test_index);
 
   // Collect network connectivity stats. This is called when all the data from
   // server is read or when there is a failure during connect/read/write. It
   // will either start the next phase of the test, or it will self destruct
-  // at the end of this method.
-  void TestPhaseComplete(Status status, int result);
+  // at the end of this method. Returns true if a new test wasn't started and it
+  // was self destructed.
+  bool TestPhaseComplete(Status status, int result);
 
   // This method is called from TestPhaseComplete() and calls
   // |finished_callback_| callback to indicate that the test has finished.
   void DoFinishCallback(int result);
 
   // Update counters/metrics for the given |probe_packet|.
   // Return true if all packets for the current test are received and
   // false otherwise.
   bool UpdateReception(const ProbePacket& probe_packet);
 
@@ skipping 184 matching lines @@
 // This starts a series of tests randomly selected among one of the three
 // choices of probe packet sizes: 100 Bytes, 500 Bytes, 1200 Bytes.
 void StartNetworkStatsTest(net::HostResolver* host_resolver,
                            const net::HostPortPair& server_address,
                            uint16 histogram_port,
                            bool has_proxy_server);
 
 }  // namespace chrome_browser_net
 
 #endif  // CHROME_BROWSER_NET_NETWORK_STATS_H_